All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Henriques <henrix@sapo.pt>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	henrix@sapo.pt, tglx@linutronix.de
Subject: [tip:irq/genirq] genirq: do not execute DEBUG_SHIRQ when irq setup failed
Date: Thu, 2 Apr 2009 14:03:30 GMT	[thread overview]
Message-ID: <tip-ba71604fad348656071a2a76eef9a67dab85a773@git.kernel.org> (raw)
In-Reply-To: <20090401170635.GA4392@hades.domain.com>

Commit-ID:  ba71604fad348656071a2a76eef9a67dab85a773
Gitweb:     http://git.kernel.org/tip/ba71604fad348656071a2a76eef9a67dab85a773
Author:     Luis Henriques <henrix@sapo.pt>
AuthorDate: Wed, 1 Apr 2009 18:06:35 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 2 Apr 2009 16:02:39 +0200

genirq: do not execute DEBUG_SHIRQ when irq setup failed

When requesting an IRQ, the DEBUG_SHIRQ code executes a fake IRQ just to make
sure the driver is ready to receive an IRQ immediately.  The problem was that
this fake IRQ was being executed even if interrupt line failed to be allocated
by __setup_irq.

Signed-off-by: Luis Henriques <henrix@sapo.pt>
LKML-Reference: <20090401170635.GA4392@hades.domain.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>


---
 kernel/irq/manage.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 1516ab7..beeb7d1 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -768,7 +768,7 @@ int request_irq(unsigned int irq, irq_handler_t handler,
 		kfree(action);
 
 #ifdef CONFIG_DEBUG_SHIRQ
-	if (irqflags & IRQF_SHARED) {
+	if (!retval & (irqflags & IRQF_SHARED)) {
 		/*
 		 * It's a shared IRQ -- the driver ought to be prepared for it
 		 * to happen immediately, so let's make sure....

  reply	other threads:[~2009-04-02 14:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01 17:06 [RESEND][PATCH -tip] irq: DEBUG_SHIRQ executed on irq setup failure Luis Henriques
2009-04-02 14:03 ` Luis Henriques [this message]
2009-04-02 14:32   ` [tip:irq/genirq] genirq: do not execute DEBUG_SHIRQ when irq setup failed Jaswinder Singh Rajput
2009-04-02 15:21     ` Thomas Gleixner
2009-04-02 15:41       ` Jaswinder Singh Rajput
2009-04-02 16:08         ` Thomas Gleixner
2009-04-02 16:20           ` Jaswinder Singh Rajput
2009-04-02 16:38             ` Thomas Gleixner
2009-04-02 16:45               ` Jaswinder Singh Rajput
2009-04-02 17:16                 ` Luis Henriques
2009-04-02 17:32             ` Ingo Molnar
2009-04-02 17:46               ` Jaswinder Singh Rajput
2009-04-02 18:01                 ` Ingo Molnar
2009-04-23  6:48 ` tip-bot for Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-ba71604fad348656071a2a76eef9a67dab85a773@git.kernel.org \
    --to=henrix@sapo.pt \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.