From: tip-bot for Prarit Bhargava <prarit@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
suresh.b.siddha@intel.com, tglx@linutronix.de, prarit@redhat.com
Subject: [tip:x86/urgent] x86: Fix NULL pointer access in irq_force_complete_move() for Xen guests
Date: Fri, 30 Apr 2010 21:36:42 GMT [thread overview]
Message-ID: <tip-bbd391a15d82e14efe9d69ba64cadb855b061dba@git.kernel.org> (raw)
In-Reply-To: <20100427152434.16193.49104.sendpatchset@prarit.bos.redhat.com>
Commit-ID: bbd391a15d82e14efe9d69ba64cadb855b061dba
Gitweb: http://git.kernel.org/tip/bbd391a15d82e14efe9d69ba64cadb855b061dba
Author: Prarit Bhargava <prarit@redhat.com>
AuthorDate: Tue, 27 Apr 2010 11:24:42 -0400
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Fri, 30 Apr 2010 14:31:38 -0700
x86: Fix NULL pointer access in irq_force_complete_move() for Xen guests
Upstream PV guests fail to boot because of a NULL pointer in
irq_force_complete_move(). It is possible that xen guests have
irq_desc->chip_data = NULL.
Test for NULL chip_data pointer before attempting to complete an irq move.
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
LKML-Reference: <20100427152434.16193.49104.sendpatchset@prarit.bos.redhat.com>
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: <stable@kernel.org> [2.6.33]
---
arch/x86/kernel/apic/io_apic.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 127b871..eb2789c 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2545,6 +2545,9 @@ void irq_force_complete_move(int irq)
struct irq_desc *desc = irq_to_desc(irq);
struct irq_cfg *cfg = desc->chip_data;
+ if (!cfg)
+ return;
+
__irq_complete_move(&desc, cfg->vector);
}
#else
next prev parent reply other threads:[~2010-04-30 21:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 15:24 [PATCH] Fix NULL pointer for Xen guests Prarit Bhargava
2010-04-27 16:58 ` [LKML] " Konrad Rzeszutek Wilk
2010-04-27 17:09 ` Prarit Bhargava
2010-04-27 17:59 ` Andrew Jones
2010-04-27 18:34 ` Konrad Rzeszutek Wilk
2010-04-27 18:47 ` Prarit Bhargava
2010-05-03 19:16 ` Konrad Rzeszutek Wilk
2010-05-03 19:56 ` Prarit Bhargava
2010-05-04 15:02 ` [LKML] " Konrad Rzeszutek Wilk
2010-05-04 15:21 ` Prarit Bhargava
2010-04-28 18:26 ` Andrew Morton
2010-04-28 18:29 ` Prarit Bhargava
2010-04-28 18:42 ` Suresh Siddha
2010-04-28 18:50 ` Andrew Morton
2010-04-28 19:15 ` [stable] " Greg KH
2010-04-30 20:55 ` H. Peter Anvin
2010-04-30 21:33 ` H. Peter Anvin
2010-04-30 22:01 ` Prarit Bhargava
2010-04-30 21:36 ` tip-bot for Prarit Bhargava [this message]
2010-05-04 15:02 ` [LKML] [tip:x86/urgent] x86: Fix NULL pointer access in irq_force_complete_move() " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-bbd391a15d82e14efe9d69ba64cadb855b061dba@git.kernel.org \
--to=prarit@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.