From: tip-bot for Joe Millenbach <jmillenbach@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
caushik1@gmail.com, jmillenbach@gmail.com, josh@joshtriplett.org,
tglx@linutronix.de
Subject: [tip:x86/boot] x86, boot: Exclude early_serial_console.c if can' t use it.
Date: Sat, 21 Jul 2012 17:58:18 -0700 [thread overview]
Message-ID: <tip-cec49df9d331feaa2fea3d24c07147c7659940d1@git.kernel.org> (raw)
In-Reply-To: <1342746282-28497-7-git-send-email-jmillenbach@gmail.com>
Commit-ID: cec49df9d331feaa2fea3d24c07147c7659940d1
Gitweb: http://git.kernel.org/tip/cec49df9d331feaa2fea3d24c07147c7659940d1
Author: Joe Millenbach <jmillenbach@gmail.com>
AuthorDate: Thu, 19 Jul 2012 18:04:41 -0700
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Sat, 21 Jul 2012 11:07:34 -0700
x86, boot: Exclude early_serial_console.c if can't use it.
Removes early_serial_console.c code if we don't have the config option that
enables it (EARLY_PRINTK). When disabling this code, make early_serial_base a
constant 0 to allow the compiler to optimize away the code that checks for
early_serial_base.
Signed-off-by: Joe Millenbach <jmillenbach@gmail.com>
Link: http://lkml.kernel.org/r/1342746282-28497-7-git-send-email-jmillenbach@gmail.com
Signed-off-by: Gokul Caushik <caushik1@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/boot/compressed/early_serial_console.c | 4 ++++
arch/x86/boot/compressed/misc.h | 10 ++++++++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/arch/x86/boot/compressed/early_serial_console.c b/arch/x86/boot/compressed/early_serial_console.c
index 261e81f..d3d003c 100644
--- a/arch/x86/boot/compressed/early_serial_console.c
+++ b/arch/x86/boot/compressed/early_serial_console.c
@@ -1,5 +1,9 @@
#include "misc.h"
+#ifdef CONFIG_EARLY_PRINTK
+
int early_serial_base;
#include "../early_serial_console.c"
+
+#endif
diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
index 618e5c8..3ffee6e 100644
--- a/arch/x86/boot/compressed/misc.h
+++ b/arch/x86/boot/compressed/misc.h
@@ -43,7 +43,17 @@ int cmdline_find_option(const char *option, char *buffer, int bufsize);
int cmdline_find_option_bool(const char *option);
/* early_serial_console.c */
+#ifdef CONFIG_EARLY_PRINTK
+
extern int early_serial_base;
void console_init(void);
+#else
+
+static const int early_serial_base;
+static inline void console_init(void)
+{ }
+
+#endif
+
#endif
next prev parent reply other threads:[~2012-07-22 0:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1342746282-28497-1-git-send-email-jmillenbach@gmail.com>
2012-07-20 1:04 ` [PATCH 1/7] x86/boot: Removed quiet flag and switched quiet output to debug flag Joe Millenbach
2012-07-22 0:53 ` [tip:x86/boot] x86, boot: " tip-bot for Joe Millenbach
2012-07-20 1:04 ` [PATCH 2/7] x86/boot: Wrap debug printing in a new debug_putstr function Joe Millenbach
2012-07-22 0:54 ` [tip:x86/boot] x86, boot: " tip-bot for Joe Millenbach
2012-07-20 1:04 ` [PATCH 3/7] x86/boot: Changed error putstr path to match new debug_putstr format Joe Millenbach
2012-07-22 0:55 ` [tip:x86/boot] x86, boot: " tip-bot for Joe Millenbach
2012-07-20 1:04 ` [PATCH 4/7] x86/boot: Switch output functions from command-line flags to conditional compilation Joe Millenbach
2012-07-22 0:56 ` [tip:x86/boot] x86, boot: " tip-bot for Joe Millenbach
2012-07-20 1:04 ` [PATCH 5/7] x86/boot: Removed unused debug flag and set code Joe Millenbach
2012-07-22 0:57 ` [tip:x86/boot] x86, boot: " tip-bot for Joe Millenbach
2012-07-20 1:04 ` [PATCH 6/7] x86/boot: Exclude early_serial_console.c if can't use it Joe Millenbach
2012-07-22 0:58 ` tip-bot for Joe Millenbach [this message]
2012-07-20 1:04 ` [PATCH 7/7] x86/boot: Exclude cmdline.c if you " Joe Millenbach
2012-07-22 0:59 ` [tip:x86/boot] x86, boot: " tip-bot for Gokul Caushik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-cec49df9d331feaa2fea3d24c07147c7659940d1@git.kernel.org \
--to=jmillenbach@gmail.com \
--cc=caushik1@gmail.com \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.