From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755755AbcBCKQH (ORCPT ); Wed, 3 Feb 2016 05:16:07 -0500 Received: from terminus.zytor.com ([198.137.202.10]:54628 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754230AbcBCKQC (ORCPT ); Wed, 3 Feb 2016 05:16:02 -0500 Date: Wed, 3 Feb 2016 02:15:48 -0800 From: tip-bot for Wang Nan Message-ID: Cc: jolsa@kernel.org, hpa@zytor.com, mingo@kernel.org, lizefan@huawei.com, tglx@linutronix.de, acme@redhat.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org Reply-To: lizefan@huawei.com, mingo@kernel.org, hpa@zytor.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, wangnan0@huawei.com, acme@redhat.com, tglx@linutronix.de In-Reply-To: <1453893742-20603-1-git-send-email-wangnan0@huawei.com> References: <1453893742-20603-1-git-send-email-wangnan0@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] tools build: Check basic headers for test-compile feature checker Git-Commit-ID: cf9162c290447cdf6fca7b64dd6e2200dc52f03b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: cf9162c290447cdf6fca7b64dd6e2200dc52f03b Gitweb: http://git.kernel.org/tip/cf9162c290447cdf6fca7b64dd6e2200dc52f03b Author: Wang Nan AuthorDate: Wed, 27 Jan 2016 11:22:22 +0000 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 27 Jan 2016 11:59:32 -0300 tools build: Check basic headers for test-compile feature checker An i386 binary can be linked correctly even without correct headers. Which causes problem. For exmaple: $ mv /tmp/oxygen_root/usr/include/gnu/stubs-32.h{,.bak} $ make tools/perf Auto-detecting system features: ... dwarf: [ on ] [SNIP] GEN common-cmds.h CC perf-read-vdso32 In file included from /tmp/oxygen_root/usr/include/features.h:388:0, from /tmp/oxygen_root/usr/include/stdio.h:27, from perf-read-vdso.c:1: /tmp/oxygen_root/usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory # include ^ compilation terminated. ... In this patch we checks not only compiler and linker, but also basic headers in test-compile test case, make it fail on a platform lacking correct headers. Signed-off-by: Wang Nan Acked-by: Jiri Olsa Cc: Li Zefan Link: http://lkml.kernel.org/r/1453893742-20603-1-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/build/feature/test-compile.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/build/feature/test-compile.c b/tools/build/feature/test-compile.c index 31dbf45..c54e655 100644 --- a/tools/build/feature/test-compile.c +++ b/tools/build/feature/test-compile.c @@ -1,4 +1,6 @@ +#include int main(void) { + printf("Hello World!\n"); return 0; }