From: tip-bot for Jiang Liu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, magnus.damm@gmail.com, mingo@kernel.org,
hpa@zytor.com, linux-kernel@vger.kernel.org,
jiang.liu@linux.intel.com, horms@verge.net.au
Subject: [tip:irq/core] sh/irq: Use irq accessor functions instead of open coded access
Date: Mon, 27 Jul 2015 08:59:40 -0700 [thread overview]
Message-ID: <tip-d1357bc730a5873aa6593883fe7eb4b94abb082e@git.kernel.org> (raw)
In-Reply-To: <20150713151626.616384365@linutronix.de>
Commit-ID: d1357bc730a5873aa6593883fe7eb4b94abb082e
Gitweb: http://git.kernel.org/tip/d1357bc730a5873aa6593883fe7eb4b94abb082e
Author: Jiang Liu <jiang.liu@linux.intel.com>
AuthorDate: Mon, 13 Jul 2015 20:51:22 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 27 Jul 2015 13:36:38 +0200
sh/irq: Use irq accessor functions instead of open coded access
This is a preparatory patch for refactoring the internals if irq_data.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>
Link: http://lkml.kernel.org/r/20150713151626.616384365@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/sh/intc/virq.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/sh/intc/virq.c b/drivers/sh/intc/virq.c
index f5f1b82..0f73530 100644
--- a/drivers/sh/intc/virq.c
+++ b/drivers/sh/intc/virq.c
@@ -83,12 +83,11 @@ EXPORT_SYMBOL_GPL(intc_irq_lookup);
static int add_virq_to_pirq(unsigned int irq, unsigned int virq)
{
- struct intc_virq_list **last, *entry;
- struct irq_data *data = irq_get_irq_data(irq);
+ struct intc_virq_list *entry;
+ struct intc_virq_list **last = NULL;
/* scan for duplicates */
- last = (struct intc_virq_list **)&data->handler_data;
- for_each_virq(entry, data->handler_data) {
+ for_each_virq(entry, irq_get_handler_data(irq)) {
if (entry->irq == virq)
return 0;
last = &entry->next;
@@ -102,7 +101,10 @@ static int add_virq_to_pirq(unsigned int irq, unsigned int virq)
entry->irq = virq;
- *last = entry;
+ if (last)
+ *last = entry;
+ else
+ irq_set_handler_data(irq, entry);
return 0;
}
next prev parent reply other threads:[~2015-07-27 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 20:51 [patch 0/5] sh: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:51 ` [patch 1/5] sh/irq: Use accessor irq_data_get_node() Thomas Gleixner
2015-07-27 15:59 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-29 8:16 ` tip-bot for Jiang Liu
2015-07-13 20:51 ` [patch 2/5] sh/irq: Use irq accessor functions instead of open coded access Thomas Gleixner
2015-07-27 15:59 ` tip-bot for Jiang Liu [this message]
2015-07-29 8:16 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-13 20:51 ` [patch 3/5] sh/irq: Use access helper irq_data_get_affinity_mask() Thomas Gleixner
2015-07-27 15:59 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-29 8:16 ` tip-bot for Thomas Gleixner
2015-07-13 20:51 ` [patch 4/5] sh/intc: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Thomas Gleixner
2015-07-27 16:00 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-29 8:17 ` tip-bot for Jiang Liu
2015-07-13 20:51 ` [patch 5/5] sh/intc: Prepare irq flow handlers for irq argument removal Thomas Gleixner
2015-07-27 16:00 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-29 8:17 ` tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d1357bc730a5873aa6593883fe7eb4b94abb082e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.