All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Nikhil Rao <ncrao@google.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	a.p.zijlstra@chello.nl, ncrao@google.com, alex.shi@intel.com,
	tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/urgent] sched: Fix idle balancing
Date: Thu, 18 Nov 2010 14:08:58 GMT	[thread overview]
Message-ID: <tip-d5ad140bc1505a98c0f040937125bfcbb508078f@git.kernel.org> (raw)
In-Reply-To: <1290022924-3548-1-git-send-email-ncrao@google.com>

Commit-ID:  d5ad140bc1505a98c0f040937125bfcbb508078f
Gitweb:     http://git.kernel.org/tip/d5ad140bc1505a98c0f040937125bfcbb508078f
Author:     Nikhil Rao <ncrao@google.com>
AuthorDate: Wed, 17 Nov 2010 11:42:04 -0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 18 Nov 2010 13:12:33 +0100

sched: Fix idle balancing

An earlier commit reverts idle balancing throttling reset to fix a 30%
regression in volanomark throughput. We still need to reset idle_stamp
when we pull a task in newidle balance.

Reported-by: Alex Shi <alex.shi@intel.com>
Signed-off-by: Nikhil Rao <ncrao@google.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1290022924-3548-1-git-send-email-ncrao@google.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched_fair.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index ba0556d..00ebd76 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -3215,8 +3215,10 @@ static void idle_balance(int this_cpu, struct rq *this_rq)
 		interval = msecs_to_jiffies(sd->balance_interval);
 		if (time_after(next_balance, sd->last_balance + interval))
 			next_balance = sd->last_balance + interval;
-		if (pulled_task)
+		if (pulled_task) {
+			this_rq->idle_stamp = 0;
 			break;
+		}
 	}
 
 	raw_spin_lock(&this_rq->lock);

  parent reply	other threads:[~2010-11-18 14:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16  9:34 [performance bug] volanomark regression on 37-rc1 Alex,Shi
2010-11-16 14:38 ` Rakib Mullick
2010-11-16 15:26   ` Mike Galbraith
2010-11-16 16:31     ` Nikhil Rao
2010-11-16 17:32       ` Mike Galbraith
2010-11-16 19:27         ` Nikhil Rao
2010-11-16 19:37           ` Peter Zijlstra
2010-11-17  1:17         ` Alex,Shi
     [not found]           ` <1290022924-3548-1-git-send-email-ncrao@google.com>
2010-11-17 19:45             ` Nikhil Rao
2010-11-18 14:08             ` tip-bot for Nikhil Rao [this message]
2010-11-18 14:08         ` [tip:sched/urgent] sched: Fix volanomark performance regression tip-bot for Alex Shi
2010-11-17  0:23   ` [performance bug] volanomark regression on 37-rc1 Alex,Shi
2010-11-16 16:21 ` Nikhil Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d5ad140bc1505a98c0f040937125bfcbb508078f@git.kernel.org \
    --to=ncrao@google.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=alex.shi@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.