All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Andreas Fenkart <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	andreas.fenkart@streamunlimited.com, tglx@linutronix.de
Subject: [tip:irq/core] genirq: Add kerneldoc for irq_disable.
Date: Wed, 29 May 2013 02:24:53 -0700	[thread overview]
Message-ID: <tip-d671a605580d2caafc77f1a25bcf8435795df6fe@git.kernel.org> (raw)
In-Reply-To: <1368181290-1583-1-git-send-email-andreas.fenkart@streamunlimited.com>

Commit-ID:  d671a605580d2caafc77f1a25bcf8435795df6fe
Gitweb:     http://git.kernel.org/tip/d671a605580d2caafc77f1a25bcf8435795df6fe
Author:     Andreas Fenkart <andreas.fenkart@streamunlimited.com>
AuthorDate: Fri, 10 May 2013 12:21:30 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 29 May 2013 11:09:10 +0200

genirq: Add kerneldoc for irq_disable.

Document the lazy disable functionality. comment based on changelog of
d209a699a0b975ad

Signed-off-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Cc: balbi@ti.com
Link: http://lkml.kernel.org/r/1368181290-1583-1-git-send-email-andreas.fenkart@streamunlimited.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/irq/chip.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index cbd97ce..a3bb14f 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -213,6 +213,19 @@ void irq_enable(struct irq_desc *desc)
 	irq_state_clr_masked(desc);
 }
 
+/**
+ * irq_disable - Mark interupt disabled
+ * @desc:	irq descriptor which should be disabled
+ *
+ * If the chip does not implement the irq_disable callback, we
+ * use a lazy disable approach. That means we mark the interrupt
+ * disabled, but leave the hardware unmasked. That's an
+ * optimization because we avoid the hardware access for the
+ * common case where no interrupt happens after we marked it
+ * disabled. If an interrupt happens, then the interrupt flow
+ * handler masks the line at the hardware level and marks it
+ * pending.
+ */
 void irq_disable(struct irq_desc *desc)
 {
 	irq_state_set_disabled(desc);

      parent reply	other threads:[~2013-05-29  9:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-10 10:21 [PATCH 1/1] genirq: outline lazy disable in kerneldoc of irq_disable function Andreas Fenkart
2013-05-10 18:10 ` Randy Dunlap
2013-05-29  9:24 ` tip-bot for Andreas Fenkart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d671a605580d2caafc77f1a25bcf8435795df6fe@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=andreas.fenkart@streamunlimited.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.