From: tip-bot for Kan Liang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, acme@redhat.com, tglx@linutronix.de,
jolsa@kernel.org, kan.liang@intel.com,
linux-kernel@vger.kernel.org, mingo@kernel.org
Subject: [tip:perf/urgent] perf evlist: Open event on evsel cpus and threads
Date: Tue, 1 Sep 2015 01:31:13 -0700 [thread overview]
Message-ID: <tip-d988d5ee647861706bc7a391ddbc29429b50f00e@git.kernel.org> (raw)
In-Reply-To: <1440138194-17001-1-git-send-email-kan.liang@intel.com>
Commit-ID: d988d5ee647861706bc7a391ddbc29429b50f00e
Gitweb: http://git.kernel.org/tip/d988d5ee647861706bc7a391ddbc29429b50f00e
Author: Kan Liang <kan.liang@intel.com>
AuthorDate: Fri, 21 Aug 2015 02:23:14 -0400
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 31 Aug 2015 17:28:01 -0300
perf evlist: Open event on evsel cpus and threads
An evsel may have different cpus and threads than the evlist it is in.
Use it's own cpus and threads, when opening the evsel in 'perf record'.
Signed-off-by: Kan Liang <kan.liang@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1440138194-17001-1-git-send-email-kan.liang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 2 +-
tools/perf/util/evlist.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index a660022..1d14f38 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -279,7 +279,7 @@ static int record__open(struct record *rec)
evlist__for_each(evlist, pos) {
try_again:
- if (perf_evsel__open(pos, evlist->cpus, evlist->threads) < 0) {
+ if (perf_evsel__open(pos, pos->cpus, pos->threads) < 0) {
if (perf_evsel__fallback(pos, errno, msg, sizeof(msg))) {
if (verbose)
ui__warning("%s\n", msg);
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 8d00039..d51a520 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1181,6 +1181,10 @@ int perf_evlist__apply_filters(struct perf_evlist *evlist, struct perf_evsel **e
if (evsel->filter == NULL)
continue;
+ /*
+ * filters only work for tracepoint event, which doesn't have cpu limit.
+ * So evlist and evsel should always be same.
+ */
err = perf_evsel__apply_filter(evsel, ncpus, nthreads, evsel->filter);
if (err) {
*err_evsel = evsel;
next prev parent reply other threads:[~2015-09-01 8:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 6:23 [PATCH 1/1] perf,tools: open event on evsel cpus and threads kan.liang
2015-08-21 13:54 ` Jiri Olsa
2015-08-31 20:31 ` Arnaldo Carvalho de Melo
2015-08-31 21:06 ` Liang, Kan
2015-08-31 21:14 ` Arnaldo Carvalho de Melo
2015-08-31 21:28 ` Liang, Kan
2015-08-31 21:34 ` Arnaldo Carvalho de Melo
2015-09-01 8:31 ` tip-bot for Kan Liang [this message]
2015-09-03 13:34 ` [tip:perf/urgent] perf evlist: Open " Adrian Hunter
2015-09-03 15:27 ` Arnaldo Carvalho de Melo
2015-09-03 16:23 ` Adrian Hunter
2015-09-03 16:41 ` Arnaldo Carvalho de Melo
2015-09-03 18:19 ` Jiri Olsa
2015-09-03 18:38 ` Adrian Hunter
2015-09-03 19:04 ` Jiri Olsa
2015-09-03 20:41 ` Arnaldo Carvalho de Melo
2015-09-04 7:05 ` Jiri Olsa
2015-09-04 7:09 ` Adrian Hunter
2015-09-04 12:15 ` [PATCH] perf tools: Fix gaps propagating maps Adrian Hunter
2015-09-04 13:28 ` Arnaldo Carvalho de Melo
2015-09-04 13:42 ` Adrian Hunter
2015-09-04 14:48 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d988d5ee647861706bc7a391ddbc29429b50f00e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.