From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbbCVKLE (ORCPT ); Sun, 22 Mar 2015 06:11:04 -0400 Received: from terminus.zytor.com ([198.137.202.10]:57103 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752438AbbCVKK7 (ORCPT ); Sun, 22 Mar 2015 06:10:59 -0400 Date: Sun, 22 Mar 2015 03:10:41 -0700 From: tip-bot for Yunlong Song Message-ID: Cc: tglx@linutronix.de, wangnan0@huawei.com, mingo@kernel.org, paulus@samba.org, hpa@zytor.com, a.p.zijlstra@chello.nl, acme@redhat.com, yunlong.song@huawei.com, linux-kernel@vger.kernel.org Reply-To: paulus@samba.org, wangnan0@huawei.com, mingo@kernel.org, tglx@linutronix.de, yunlong.song@huawei.com, linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com, a.p.zijlstra@chello.nl In-Reply-To: <1426685758-25488-7-git-send-email-yunlong.song@huawei.com> References: <1426685758-25488-7-git-send-email-yunlong.song@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Fix the bash completion for listing subcommands of perf Git-Commit-ID: e003ce54d2ccbb8da0fd4f421e1cc9686ef25add X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e003ce54d2ccbb8da0fd4f421e1cc9686ef25add Gitweb: http://git.kernel.org/tip/e003ce54d2ccbb8da0fd4f421e1cc9686ef25add Author: Yunlong Song AuthorDate: Wed, 18 Mar 2015 21:35:51 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 19 Mar 2015 13:49:38 -0300 perf tools: Fix the bash completion for listing subcommands of perf The bash completion does not support listing subcommands for 'perf -- '. Example: Before this patch: $ perf --debug $ As shown above, the subcommands of perf does not come out. After this patch: $ perf --debug annotate buildid-cache data evlist inject kvm lock probe report script test top version bench buildid-list diff help kmem list mem record sched stat timechart trace As shown above, the subcommands of perf can come out now. Signed-off-by: Yunlong Song Tested-by: Arnaldo Carvalho de Melo Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Wang Nan Link: http://lkml.kernel.org/r/1426685758-25488-7-git-send-email-yunlong.song@huawei.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/perf-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh index 3e25d3e..7b98ae4 100644 --- a/tools/perf/perf-completion.sh +++ b/tools/perf/perf-completion.sh @@ -130,7 +130,7 @@ __perf_main () # Skip options backward and find the last perf command __perf_prev_skip_opts # List perf subcommands or long options - if [ $cword -eq 1 ]; then + if [ -z $prev_skip_opts ]; then if [[ $cur == --* ]]; then cmds=$($cmd --list-opts) else