All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Yinghai Lu <yinghai@kernel.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	yinghai@kernel.org, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/apic] x86: apic: Remove not needed #ifdef
Date: Mon, 23 Nov 2009 11:51:47 GMT	[thread overview]
Message-ID: <tip-e670761f12f4069d204f433bf547d9c679a4fd05@git.kernel.org> (raw)
In-Reply-To: <4B07A739.3030104@kernel.org>

Commit-ID:  e670761f12f4069d204f433bf547d9c679a4fd05
Gitweb:     http://git.kernel.org/tip/e670761f12f4069d204f433bf547d9c679a4fd05
Author:     Yinghai Lu <yinghai@kernel.org>
AuthorDate: Sat, 21 Nov 2009 00:23:37 -0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 23 Nov 2009 09:54:15 +0100

x86: apic: Remove not needed #ifdef

Suresh made dmar_table_init() already have that protection.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <4B07A739.3030104@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/apic/apic.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 4c689f4..ad8c75b 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1377,14 +1377,11 @@ void __init enable_IR_x2apic(void)
 	unsigned long flags;
 	struct IO_APIC_route_entry **ioapic_entries = NULL;
 	int ret, x2apic_enabled = 0;
-	int dmar_table_init_ret = 0;
+	int dmar_table_init_ret;
 
-#ifdef CONFIG_INTR_REMAP
 	dmar_table_init_ret = dmar_table_init();
-	if (dmar_table_init_ret)
-		pr_debug("dmar_table_init() failed with %d:\n",
-				dmar_table_init_ret);
-#endif
+	if (dmar_table_init_ret && !x2apic_supported())
+		return;
 
 	ioapic_entries = alloc_ioapic_entries();
 	if (!ioapic_entries) {

  reply	other threads:[~2009-11-23 11:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-21  8:35 pci related patches 11-21-2009 Yinghai Lu
2009-11-21  8:39 ` x86 " Yinghai Lu
2009-11-23 11:51   ` tip-bot for Yinghai Lu [this message]
2009-11-23 11:52   ` [tip:x86/apic] x86: Re-get cfg_new in case reuse/move irq_desc tip-bot for Yinghai Lu
2009-11-23 11:52   ` [tip:x86/apic] x86: apic: Print out SRAT table APIC id in hex tip-bot for Yinghai Lu
2009-11-23 11:52   ` [tip:x86/mm] x86, numa, bootmem: Only free bootmem on NUMA failure path tip-bot for Yinghai Lu
2009-11-23 11:52   ` [tip:x86/mm] x86, numa: Use near(er) online node instead of roundrobin for NUMA tip-bot for Yinghai Lu
2009-12-16  2:06   ` x86 related patches 12-15-2009 Yinghai Lu
2009-11-24 21:26 ` pci related patches 11-21-2009 Jesse Barnes
2009-11-25  2:16   ` Yinghai Lu
2009-11-25  4:45     ` Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-e670761f12f4069d204f433bf547d9c679a4fd05@git.kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.