From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
tglx@linutronix.de, hjl.tools@gmail.com,
gregory.m.lueck@intel.com
Subject: [tip:x86/x32] x32: Switch to a 64-bit clock_t
Date: Mon, 5 Mar 2012 16:56:55 -0800 [thread overview]
Message-ID: <tip-e7084fd52ed71249ab2ce7a7d89d601c9d1f904c@git.kernel.org> (raw)
In-Reply-To: <1329696488-16970-1-git-send-email-hpa@zytor.com>
Commit-ID: e7084fd52ed71249ab2ce7a7d89d601c9d1f904c
Gitweb: http://git.kernel.org/tip/e7084fd52ed71249ab2ce7a7d89d601c9d1f904c
Author: H. Peter Anvin <hpa@zytor.com>
AuthorDate: Mon, 5 Mar 2012 13:40:24 -0800
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Mon, 5 Mar 2012 15:35:18 -0800
x32: Switch to a 64-bit clock_t
clock_t is used mainly to give the number of jiffies a certain process
has burned. It is entirely feasible for a long-running process to
consume more than 2^32 jiffies especially in a multiprocess system.
As such, switch to a 64-bit clock_t for x32, just as we already
switched to a 64-bit time_t.
clock_t is only used in a handful of places, and as such it is really
not a very significant change. The one that has the biggest impact is
in struct siginfo, but since the *size* of struct siginfo doesn't
change (it is padded to the hilt) it is fairly easy to make this a
localized change.
This also gets rid of sys_x32_times, however since this is a pretty
late change don't compactify the system call numbers; we can reuse
system call slot 521 next time we need an x32 system call.
Reported-by: Gregory M. Lueck <gregory.m.lueck@intel.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: H. J. Lu <hjl.tools@gmail.com>
Link: http://lkml.kernel.org/r/1329696488-16970-1-git-send-email-hpa@zytor.com
---
arch/x86/ia32/ia32_signal.c | 10 ++++++++--
arch/x86/include/asm/ia32.h | 9 +++++++++
arch/x86/syscalls/syscall_64.tbl | 4 ++--
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c
index 25d80f3..bc09ed2 100644
--- a/arch/x86/ia32/ia32_signal.c
+++ b/arch/x86/ia32/ia32_signal.c
@@ -37,6 +37,7 @@
int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from)
{
int err = 0;
+ bool ia32 = !is_ia32_task();
if (!access_ok(VERIFY_WRITE, to, sizeof(compat_siginfo_t)))
return -EFAULT;
@@ -66,8 +67,13 @@ int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from)
case __SI_FAULT >> 16:
break;
case __SI_CHLD >> 16:
- put_user_ex(from->si_utime, &to->si_utime);
- put_user_ex(from->si_stime, &to->si_stime);
+ if (ia32) {
+ put_user_ex(from->si_utime, &to->si_utime);
+ put_user_ex(from->si_stime, &to->si_stime);
+ } else {
+ put_user_ex(from->si_utime, &to->_sifields._sigchld_x32._utime);
+ put_user_ex(from->si_stime, &to->_sifields._sigchld_x32._stime);
+ }
put_user_ex(from->si_status, &to->si_status);
/* FALL THROUGH */
default:
diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h
index c6435ab..7d0c185 100644
--- a/arch/x86/include/asm/ia32.h
+++ b/arch/x86/include/asm/ia32.h
@@ -125,6 +125,15 @@ typedef struct compat_siginfo {
compat_clock_t _stime;
} _sigchld;
+ /* SIGCHLD (x32 version) */
+ struct {
+ unsigned int _pid; /* which child */
+ unsigned int _uid; /* sender's uid */
+ int _status; /* exit code */
+ s64 _utime;
+ s64 _stime;
+ } _sigchld_x32;
+
/* SIGILL, SIGFPE, SIGSEGV, SIGBUS */
struct {
unsigned int _addr; /* faulting insn/memory ref. */
diff --git a/arch/x86/syscalls/syscall_64.tbl b/arch/x86/syscalls/syscall_64.tbl
index 4aecc7e..0d778b8 100644
--- a/arch/x86/syscalls/syscall_64.tbl
+++ b/arch/x86/syscalls/syscall_64.tbl
@@ -106,7 +106,7 @@
97 common getrlimit sys_getrlimit
98 common getrusage sys_getrusage
99 common sysinfo sys_sysinfo
-100 64 times sys_times
+100 common times sys_times
101 common ptrace sys_ptrace
102 common getuid sys_getuid
103 common syslog sys_syslog
@@ -331,7 +331,7 @@
518 x32 sendmsg compat_sys_sendmsg
519 x32 recvmsg compat_sys_recvmsg
520 x32 execve stub_x32_execve
-521 x32 times compat_sys_times
+# 521 available
522 x32 rt_sigpending sys32_rt_sigpending
523 x32 rt_sigtimedwait compat_sys_rt_sigtimedwait
524 x32 rt_sigqueueinfo sys32_rt_sigqueueinfo
next prev parent reply other threads:[~2012-03-06 0:57 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 0:07 [PATCH 00/30] RFC: x32 support H. Peter Anvin
2012-02-20 0:07 ` [PATCH 01/30] x86: Factor out TIF_IA32 from 32-bit address space H. Peter Anvin
2012-02-20 0:07 ` [PATCH 02/30] x86-64: Use explicit sizes in sigcontext.h, prepare for x32 H. Peter Anvin
2012-02-20 0:51 ` Linus Torvalds
2012-02-20 0:56 ` H. Peter Anvin
2012-02-22 12:22 ` Arnd Bergmann
2012-02-22 18:14 ` H. Peter Anvin
2012-02-22 21:23 ` Arnd Bergmann
2012-02-22 21:55 ` H. Peter Anvin
2012-02-24 2:33 ` H. Peter Anvin
2012-03-06 5:25 ` H. Peter Anvin
2012-02-20 0:07 ` [PATCH 03/30] sysinfo: Move struct sysinfo to a separate header file H. Peter Anvin
2012-02-20 0:07 ` [PATCH 04/30] posix_types: Introduce __kernel_[u]long_t H. Peter Anvin
2012-02-20 0:07 ` [PATCH 05/30] x32: Create posix_types_x32.h H. Peter Anvin
2012-02-20 0:07 ` [PATCH 06/30] sysinfo: Use explicit types in <linux/sysinfo.h> H. Peter Anvin
2012-02-20 12:12 ` Geert Uytterhoeven
2012-02-20 17:29 ` H. Peter Anvin
2012-02-20 20:01 ` Geert Uytterhoeven
2012-02-20 20:44 ` H. Peter Anvin
2012-02-20 0:07 ` [PATCH 07/30] compat: Introduce COMPAT_USE_64BIT_TIME H. Peter Anvin
2012-02-20 0:07 ` [PATCH 08/30] compat: Use COMPAT_USE_64BIT_TIME in the lp driver H. Peter Anvin
2012-02-20 0:56 ` Linus Torvalds
2012-02-20 0:59 ` H. Peter Anvin
2012-02-20 2:22 ` [PATCH 0/7] COMPAT_USE_64BIT_TIME v2 H. Peter Anvin
2012-02-20 2:22 ` [PATCH 1/7] compat: Introduce COMPAT_USE_64BIT_TIME H. Peter Anvin
2012-02-20 2:22 ` [PATCH 2/7] compat: Add helper functions to read/write struct timeval, timespec H. Peter Anvin
2012-02-20 2:22 ` [PATCH 3/7] compat: Handle COMPAT_USE_64BIT_TIME in the lp driver H. Peter Anvin
2012-02-20 2:22 ` [PATCH 4/7] compat: Use COMPAT_USE_64BIT_TIME in the input subsystem H. Peter Anvin
2012-02-20 2:22 ` [PATCH 5/7] compat: Use COMPAT_USE_64BIT_TIME in the Bluetooth subsystem H. Peter Anvin
2012-02-20 2:22 ` [PATCH 6/7] compat: Use COMPAT_USE_64BIT_TIME in net/compat.c H. Peter Anvin
2012-02-20 2:22 ` [PATCH 7/7] compat: Handle COMPAT_USE_64BIT_TIME in net/socket.c H. Peter Anvin
2012-02-20 2:42 ` [PATCH 0/7] COMPAT_USE_64BIT_TIME v2 H. Peter Anvin
2012-02-20 6:22 ` H. Peter Anvin
2012-02-20 0:07 ` [PATCH 09/30] compat: Use COMPAT_USE_64BIT_TIME in the input subsystem H. Peter Anvin
2012-02-20 0:07 ` [PATCH 10/30] compat: Use COMPAT_USE_64BIT_TIME in the Bluetooth subsystem H. Peter Anvin
2012-02-21 19:05 ` Gustavo Padovan
2012-02-21 19:15 ` H. Peter Anvin
2012-02-22 13:47 ` Jiri Kosina
2012-02-22 14:45 ` Gustavo Padovan
2012-02-20 0:07 ` [PATCH 11/30] aio: Use __kernel_ulong_t to define aio_context_t H. Peter Anvin
2012-02-20 0:07 ` [PATCH 12/30] compat: Create compat_sys_p{read,write}v64 H. Peter Anvin
2012-02-20 0:07 ` [PATCH 13/30] elf: Allow core dump-related fields to be overridden H. Peter Anvin
2012-02-20 0:07 ` [PATCH 14/30] x86-64: Add prototype for old_rsp to a header file H. Peter Anvin
2012-02-20 0:07 ` [PATCH 15/30] x32: Add a thread flag for x32 processes H. Peter Anvin
2012-02-20 0:07 ` [PATCH 16/30] x86-64, ia32: Drop sys32_rt_sigprocmask H. Peter Anvin
2012-02-20 0:07 ` [PATCH 17/30] x32: Add x32 system calls to syscall/syscall_64.tbl H. Peter Anvin
2012-02-20 0:07 ` [PATCH 18/30] x32: Generate <asm/unistd_x32.h> H. Peter Anvin
2012-02-20 0:07 ` [PATCH 19/30] x32: Generate <asm/unistd_64_x32.h> H. Peter Anvin
2012-02-20 0:07 ` [PATCH 20/30] x86: Move some signal-handling definitions to a common header H. Peter Anvin
2012-02-20 0:07 ` [PATCH 21/30] x32: Export setup/restore_sigcontext from signal.c H. Peter Anvin
2012-02-20 0:08 ` [PATCH 22/30] x32: Add struct ucontext_x32 H. Peter Anvin
2012-02-20 0:08 ` [PATCH 23/30] x32: Add rt_sigframe_x32 H. Peter Anvin
2012-02-20 0:08 ` [PATCH 24/30] x32: Handle the x32 system call flag H. Peter Anvin
2012-02-20 0:08 ` [PATCH 25/30] x86: Add #ifdef CONFIG_COMPAT to <asm/sys_ia32.h> H. Peter Anvin
2012-02-20 0:08 ` [PATCH 26/30] x32: Signal-related system calls H. Peter Anvin
2012-02-20 0:08 ` [PATCH 27/30] x32: Handle process creation H. Peter Anvin
2012-02-20 0:08 ` [PATCH 28/30] x32: If configured, add x32 system calls to system call tables H. Peter Anvin
2012-02-20 0:08 ` [PATCH 29/30] x32: Allow x32 to be configured H. Peter Anvin
2012-02-20 0:08 ` [PATCH 30/30] x32: Add x32 VDSO support H. Peter Anvin
2012-02-21 0:12 ` Andy Lutomirski
2012-02-21 3:58 ` H. Peter Anvin
2012-02-21 16:52 ` Andrew Lutomirski
2012-02-21 17:51 ` H. Peter Anvin
2012-02-21 18:54 ` Andrew Lutomirski
2012-02-21 19:03 ` H. Peter Anvin
2012-02-21 19:29 ` Andrew Lutomirski
2012-02-21 19:37 ` H. Peter Anvin
2012-02-21 19:40 ` Andrew Lutomirski
2012-02-21 19:49 ` H. Peter Anvin
2012-02-21 19:51 ` Andrew Lutomirski
2012-02-21 19:56 ` H. Peter Anvin
2012-02-23 4:49 ` [tip:x86/x32] x32: Drop non-__vdso weak symbols from the x32 VDSO tip-bot for H. Peter Anvin
2012-02-23 10:55 ` Ingo Molnar
2012-02-23 14:36 ` H. Peter Anvin
2012-02-27 22:21 ` [tip:x86/x32] x32: Warn and disable rather than error if binutils too old tip-bot for H. Peter Anvin
2012-02-27 22:49 ` Fwd: " H. Peter Anvin
2012-02-27 22:51 ` H. Peter Anvin
2012-02-28 7:21 ` Sam Ravnborg
2012-02-28 9:49 ` [tip:x86/x32] x86/x32: Fix the binutils auto-detect tip-bot for Ingo Molnar
2012-03-06 0:56 ` [tip:x86/x32] x32: Provide separate is_ia32_task() and is_x32_task () predicates tip-bot for H. Peter Anvin
2012-03-06 0:56 ` tip-bot for H. Peter Anvin [this message]
2012-03-06 0:57 ` [tip:x86/x32] x32: Add ptrace for x32 tip-bot for H.J. Lu
2012-03-14 5:58 ` [tip:x86/x32] x32: Fix stupid ia32/ x32 inversion in the siginfo format tip-bot for H. Peter Anvin
2012-03-14 21:43 ` [tip:x86/x32] x32: Fix alignment fail in struct compat_siginfo tip-bot for H. Peter Anvin
2012-03-14 23:17 ` H.J. Lu
2012-03-14 23:19 ` H. Peter Anvin
2012-03-15 0:33 ` H.J. Lu
2012-03-14 23:33 ` Derek Fawcus
2012-03-14 23:44 ` H. Peter Anvin
2012-04-18 17:38 ` H.J. Lu
2012-04-18 17:47 ` H. Peter Anvin
2012-04-18 18:01 ` H.J. Lu
2012-04-18 18:10 ` H. Peter Anvin
2012-04-18 18:15 ` H.J. Lu
2012-04-18 18:21 ` H. Peter Anvin
2012-04-18 18:33 ` H.J. Lu
2012-04-18 19:03 ` H. Peter Anvin
2012-04-18 21:24 ` H. Peter Anvin
2012-04-18 21:49 ` H.J. Lu
2012-04-18 21:58 ` H. Peter Anvin
2012-04-18 22:58 ` H.J. Lu
2012-04-18 22:55 ` H.J. Lu
2012-04-18 23:48 ` H. Peter Anvin
2012-04-18 23:54 ` H.J. Lu
2012-04-19 0:09 ` H. Peter Anvin
2012-04-19 0:14 ` H.J. Lu
2012-04-23 23:49 ` [tip:x86/urgent] asm-generic: Allow overriding clock_t and add attributes to siginfo_t tip-bot for H. Peter Anvin
2012-04-23 23:50 ` [tip:x86/urgent] x32, siginfo: Provide proper overrides for x32 siginfo_t tip-bot for H. Peter Anvin
2012-04-24 1:19 ` tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e7084fd52ed71249ab2ce7a7d89d601c9d1f904c@git.kernel.org \
--to=hpa@zytor.com \
--cc=gregory.m.lueck@intel.com \
--cc=hjl.tools@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.