All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Kefeng Wang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com,
	tglx@linutronix.de, mingo@kernel.org, marc.zyngier@arm.com,
	mojha@codeaurora.org, hpa@zytor.com
Subject: [tip:irq/urgent] genirq: Initialize request_mutex if CONFIG_SPARSE_IRQ=n
Date: Fri, 5 Apr 2019 05:43:54 -0700	[thread overview]
Message-ID: <tip-e8458e7afa855317b14915d7b86ab3caceea7eb6@git.kernel.org> (raw)
In-Reply-To: <20190404074512.145533-1-wangkefeng.wang@huawei.com>

Commit-ID:  e8458e7afa855317b14915d7b86ab3caceea7eb6
Gitweb:     https://git.kernel.org/tip/e8458e7afa855317b14915d7b86ab3caceea7eb6
Author:     Kefeng Wang <wangkefeng.wang@huawei.com>
AuthorDate: Thu, 4 Apr 2019 15:45:12 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 5 Apr 2019 14:37:56 +0200

genirq: Initialize request_mutex if CONFIG_SPARSE_IRQ=n

When CONFIG_SPARSE_IRQ is disable, the request_mutex in struct irq_desc
is not initialized which causes malfunction.

Fixes: 9114014cf4e6 ("genirq: Add mutex to irq desc to serialize request/free_irq()")
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20190404074512.145533-1-wangkefeng.wang@huawei.com

---
 kernel/irq/irqdesc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 13539e12cd80..9f8a709337cf 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -558,6 +558,7 @@ int __init early_irq_init(void)
 		alloc_masks(&desc[i], node);
 		raw_spin_lock_init(&desc[i].lock);
 		lockdep_set_class(&desc[i].lock, &irq_desc_lock_class);
+		mutex_init(&desc[i].request_mutex);
 		desc_set_defaults(i, &desc[i], node, NULL, NULL);
 	}
 	return arch_early_irq_init();

      parent reply	other threads:[~2019-04-05 12:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04  7:45 [PATCH] genirq: Fix uninitialized request_mutex Kefeng Wang
2019-04-04  7:45 ` Kefeng Wang
2019-04-04  7:59 ` Mukesh Ojha
2019-04-04  7:59   ` Mukesh Ojha
2019-04-05 12:43 ` tip-bot for Kefeng Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-e8458e7afa855317b14915d7b86ab3caceea7eb6@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mingo@kernel.org \
    --cc=mojha@codeaurora.org \
    --cc=tglx@linutronix.de \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.