From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756142AbdJJLE2 (ORCPT ); Tue, 10 Oct 2017 07:04:28 -0400 Received: from terminus.zytor.com ([65.50.211.136]:39675 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756096AbdJJLEY (ORCPT ); Tue, 10 Oct 2017 07:04:24 -0400 Date: Tue, 10 Oct 2017 03:58:42 -0700 From: tip-bot for Brendan Jackman Message-ID: Cc: mingo@kernel.org, andresoportus@google.com, tglx@linutronix.de, brendan.jackman@arm.com, dietmar.eggemann@arm.com, vincent.guittot@linaro.org, torvalds@linux-foundation.org, morten.rasmussen@arm.com, joelaf@google.com, hpa@zytor.com, efault@gmx.de, peterz@infradead.org, josef@toxicpanda.com, linux-kernel@vger.kernel.org Reply-To: morten.rasmussen@arm.com, joelaf@google.com, dietmar.eggemann@arm.com, vincent.guittot@linaro.org, torvalds@linux-foundation.org, josef@toxicpanda.com, linux-kernel@vger.kernel.org, hpa@zytor.com, efault@gmx.de, peterz@infradead.org, mingo@kernel.org, andresoportus@google.com, brendan.jackman@arm.com, tglx@linutronix.de In-Reply-To: <20170808095519.10077-1-brendan.jackman@arm.com> References: <20170808095519.10077-1-brendan.jackman@arm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/fair: Sync task util before slow-path wakeup Git-Commit-ID: ea16f0ea6c3dc9e1aa083bd3d1792ba02860526e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: ea16f0ea6c3dc9e1aa083bd3d1792ba02860526e Gitweb: https://git.kernel.org/tip/ea16f0ea6c3dc9e1aa083bd3d1792ba02860526e Author: Brendan Jackman AuthorDate: Thu, 5 Oct 2017 11:55:51 +0100 Committer: Ingo Molnar CommitDate: Tue, 10 Oct 2017 11:45:31 +0200 sched/fair: Sync task util before slow-path wakeup We use task_util() in find_idlest_group() via capacity_spare_wake(). This task_util() updated in wake_cap(). However wake_cap() is not the only reason for ending up in find_idlest_group() - we could have been sent there by wake_wide(). So explicitly sync the task util with prev_cpu when we are about to head to find_idlest_group(). We could simply do this at the beginning of select_task_rq_fair() (i.e. irrespective of whether we're heading to select_idle_sibling() or find_idlest_group() & co), but I didn't want to slow down the select_idle_sibling() path more than necessary. Don't do this during fork balancing, we won't need the task_util and we'd just clobber the last_update_time, which is supposed to be 0. Signed-off-by: Brendan Jackman Signed-off-by: Peter Zijlstra (Intel) Cc: Andres Oportus Cc: Dietmar Eggemann Cc: Joel Fernandes Cc: Josef Bacik Cc: Linus Torvalds Cc: Mike Galbraith Cc: Morten Rasmussen Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Vincent Guittot Link: http://lkml.kernel.org/r/20170808095519.10077-1-brendan.jackman@arm.com Signed-off-by: Ingo Molnar --- kernel/sched/fair.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index cc0bfb0..c04a425 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6263,8 +6263,17 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f new_cpu = cpu; } + if (sd && !(sd_flag & SD_BALANCE_FORK)) { + /* + * We're going to need the task's util for capacity_spare_wake + * in find_idlest_group. Sync it up to prev_cpu's + * last_update_time. + */ + sync_entity_load_avg(&p->se); + } + if (!sd) { - pick_cpu: +pick_cpu: if (sd_flag & SD_BALANCE_WAKE) /* XXX always ? */ new_cpu = select_idle_sibling(p, prev_cpu, new_cpu);