From: tip-bot for Josh Poimboeuf <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: brgerst@gmail.com, torvalds@linux-foundation.org,
luto@kernel.org, nilayvaish@gmail.com, mingo@kernel.org,
bp@alien8.de, byungchul.park@lge.com, peterz@infradead.org,
tglx@linutronix.de, jpoimboe@redhat.com, fweisbec@gmail.com,
keescook@chromium.org, dvlasenk@redhat.com, luto@amacapital.net,
hpa@zytor.com, rostedt@goodmis.org, rric@kernel.org,
linux-kernel@vger.kernel.org
Subject: [tip:x86/asm] oprofile/x86: Convert x86_backtrace() to use the new unwinder
Date: Tue, 20 Sep 2016 08:00:36 -0700 [thread overview]
Message-ID: <tip-ec2ad9ccf12dc965cad2d367a4063f68d6561a6b@git.kernel.org> (raw)
In-Reply-To: <412df8927705795e8ea60cffcf89a79e010713b1.1474045023.git.jpoimboe@redhat.com>
Commit-ID: ec2ad9ccf12dc965cad2d367a4063f68d6561a6b
Gitweb: http://git.kernel.org/tip/ec2ad9ccf12dc965cad2d367a4063f68d6561a6b
Author: Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Fri, 16 Sep 2016 14:18:15 -0500
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 20 Sep 2016 08:29:34 +0200
oprofile/x86: Convert x86_backtrace() to use the new unwinder
Convert oprofile's x86_backtrace() to use the new unwinder.
dump_trace() has been deprecated.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nilay Vaish <nilayvaish@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <rric@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/412df8927705795e8ea60cffcf89a79e010713b1.1474045023.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/oprofile/backtrace.c | 39 +++++++++++++++++----------------------
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/arch/x86/oprofile/backtrace.c b/arch/x86/oprofile/backtrace.c
index 7539148..a2488b6 100644
--- a/arch/x86/oprofile/backtrace.c
+++ b/arch/x86/oprofile/backtrace.c
@@ -16,27 +16,7 @@
#include <asm/ptrace.h>
#include <asm/stacktrace.h>
-
-static int backtrace_stack(void *data, const char *name)
-{
- /* Yes, we want all stacks */
- return 0;
-}
-
-static int backtrace_address(void *data, unsigned long addr, int reliable)
-{
- unsigned int *depth = data;
-
- if ((*depth)--)
- oprofile_add_trace(addr);
- return 0;
-}
-
-static struct stacktrace_ops backtrace_ops = {
- .stack = backtrace_stack,
- .address = backtrace_address,
- .walk_stack = print_context_stack,
-};
+#include <asm/unwind.h>
#ifdef CONFIG_COMPAT
static struct stack_frame_ia32 *
@@ -113,14 +93,29 @@ x86_backtrace(struct pt_regs * const regs, unsigned int depth)
struct stack_frame *head = (struct stack_frame *)frame_pointer(regs);
if (!user_mode(regs)) {
+ struct unwind_state state;
+ unsigned long addr;
+
if (!depth)
return;
oprofile_add_trace(regs->ip);
+
if (!--depth)
return;
- dump_trace(NULL, regs, NULL, 0, &backtrace_ops, &depth);
+ for (unwind_start(&state, current, regs, NULL);
+ !unwind_done(&state); unwind_next_frame(&state)) {
+ addr = unwind_get_return_address(&state);
+ if (!addr)
+ break;
+
+ oprofile_add_trace(addr);
+
+ if (!--depth)
+ break;
+ }
+
return;
}
next prev parent reply other threads:[~2016-09-20 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 19:18 [PATCH v2 0/6] x86/dumpstack: replace dump_trace() with a new unwinder Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 1/6] x86/unwind: add new unwind interface and implementations Josh Poimboeuf
2016-09-20 14:59 ` [tip:x86/asm] x86/unwind: Add " tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 2/6] perf/x86: convert perf_callchain_kernel() to use the new unwinder Josh Poimboeuf
2016-09-20 14:59 ` [tip:x86/asm] perf/x86: Convert " tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 3/6] x86/stacktrace: convert save_stack_trace_*() " Josh Poimboeuf
2016-09-20 15:00 ` [tip:x86/asm] x86/stacktrace: Convert " tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 4/6] oprofile/x86: convert x86_backtrace() " Josh Poimboeuf
2016-09-20 15:00 ` tip-bot for Josh Poimboeuf [this message]
2016-09-16 19:18 ` [PATCH v2 5/6] x86/dumpstack: convert show_trace_log_lvl() " Josh Poimboeuf
2016-09-20 15:01 ` [tip:x86/asm] x86/dumpstack: Convert " tip-bot for Josh Poimboeuf
2016-09-20 15:53 ` [PATCH] x86/dumpstack: fix show_stack() task pointer regression Josh Poimboeuf
2016-09-20 21:48 ` [tip:x86/asm] x86/dumpstack: Fix " tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 6/6] x86/dumpstack: remove dump_trace() and related callbacks Josh Poimboeuf
2016-09-20 15:01 ` [tip:x86/asm] x86/dumpstack: Remove " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ec2ad9ccf12dc965cad2d367a4063f68d6561a6b@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=byungchul.park@lge.com \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=nilayvaish@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rric@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.