From: tip-bot for Jan Stancek <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: fweisbec@gmail.com, mingo@kernel.org,
cjashfor@linux.vnet.ibm.com, acme@redhat.com, paulus@samba.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
jstancek@redhat.com, adrian.hunter@intel.com, dsahern@gmail.com,
namhyung@kernel.org, jolsa@kernel.org, a.p.zijlstra@chello.nl,
hpa@zytor.com
Subject: [tip:perf/core] perf tests: Print objdump/dso buffers if they don 't match
Date: Mon, 14 Sep 2015 23:58:43 -0700 [thread overview]
Message-ID: <tip-fd405cf6cfddd300377bd5fd9b93d2ff66fbc32d@git.kernel.org> (raw)
In-Reply-To: <d0f42f786bc0e965918e0f422df25617a12a4021.1441181335.git.jstancek@redhat.com>
Commit-ID: fd405cf6cfddd300377bd5fd9b93d2ff66fbc32d
Gitweb: http://git.kernel.org/tip/fd405cf6cfddd300377bd5fd9b93d2ff66fbc32d
Author: Jan Stancek <jstancek@redhat.com>
AuthorDate: Wed, 2 Sep 2015 10:19:17 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 14 Sep 2015 12:50:13 -0300
perf tests: Print objdump/dso buffers if they don't match
Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/d0f42f786bc0e965918e0f422df25617a12a4021.1441181335.git.jstancek@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/tests/code-reading.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c
index 8145c67..2d21183 100644
--- a/tools/perf/tests/code-reading.c
+++ b/tools/perf/tests/code-reading.c
@@ -162,6 +162,18 @@ static int read_via_objdump(const char *filename, u64 addr, void *buf,
return ret;
}
+static void dump_buf(unsigned char *buf, size_t len)
+{
+ size_t i;
+
+ for (i = 0; i < len; i++) {
+ pr_debug("0x%02x ", buf[i]);
+ if (i % 16 == 15)
+ pr_debug("\n");
+ }
+ pr_debug("\n");
+}
+
static int read_object_code(u64 addr, size_t len, u8 cpumode,
struct thread *thread, struct state *state)
{
@@ -264,6 +276,10 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,
/* The results should be identical */
if (memcmp(buf1, buf2, len)) {
pr_debug("Bytes read differ from those read by objdump\n");
+ pr_debug("buf1 (dso):\n");
+ dump_buf(buf1, len);
+ pr_debug("buf2 (objdump):\n");
+ dump_buf(buf2, len);
return -1;
}
pr_debug("Bytes read match those read by objdump\n");
next prev parent reply other threads:[~2015-09-15 6:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 8:19 [PATCH v2 1/4] perf tests: take into account address of each objdump line Jan Stancek
2015-09-02 8:19 ` [PATCH v2 2/4] perf tests: make objdump disassemble zero blocks Jan Stancek
2015-09-03 9:11 ` Adrian Hunter
2015-09-03 11:23 ` [PATCH v3 " Jan Stancek
2015-09-03 11:35 ` Adrian Hunter
2015-09-03 15:14 ` Arnaldo Carvalho de Melo
2015-09-03 16:19 ` Jan Stancek
2015-09-03 16:37 ` Arnaldo Carvalho de Melo
2015-09-15 6:58 ` [tip:perf/core] perf tests: Make " tip-bot for Jan Stancek
2015-09-02 8:19 ` [PATCH v2 3/4] perf tests: stop reading if objdump output crossed sections Jan Stancek
2015-09-03 9:12 ` Adrian Hunter
2015-09-15 6:58 ` [tip:perf/core] perf tests: Stop " tip-bot for Jan Stancek
2015-09-02 8:19 ` [PATCH v2 4/4] perf tests: print objdump/dso buffers if they don't match Jan Stancek
2015-09-03 9:12 ` Adrian Hunter
2015-09-15 6:58 ` tip-bot for Jan Stancek [this message]
2015-09-03 9:08 ` [PATCH v2 1/4] perf tests: take into account address of each objdump line Adrian Hunter
2015-09-03 11:23 ` [PATCH v3 " Jan Stancek
2015-09-03 11:35 ` Adrian Hunter
2015-09-15 6:57 ` [tip:perf/core] perf tests: Take " tip-bot for Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-fd405cf6cfddd300377bd5fd9b93d2ff66fbc32d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.