All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Milo Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tony@atomide.com, linux-kernel@vger.kernel.org, mingo@kernel.org,
	tglx@linutronix.de, marc.zyngier@arm.com, milo.kim@ti.com,
	jason@lakedaemon.net, hpa@zytor.com
Subject: [tip:irq/core] irqchip/omap-intc: Remove duplicate setup for IRQ chip type handler
Date: Tue, 29 Dec 2015 03:05:17 -0800	[thread overview]
Message-ID: <tip-fee48dfcd76b21b9a7117c3014e1345697ff08ec@git.kernel.org> (raw)
In-Reply-To: <1450687994-12580-1-git-send-email-milo.kim@ti.com>

Commit-ID:  fee48dfcd76b21b9a7117c3014e1345697ff08ec
Gitweb:     http://git.kernel.org/tip/fee48dfcd76b21b9a7117c3014e1345697ff08ec
Author:     Milo Kim <milo.kim@ti.com>
AuthorDate: Mon, 21 Dec 2015 17:53:14 +0900
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 29 Dec 2015 11:58:54 +0100

irqchip/omap-intc: Remove duplicate setup for IRQ chip type handler

Some OMAP interrupt controllers use generic level detection, so
handle_level_irq() is used as the chip type handler.
Allocated IRQ chip type handler doesn't need to set it again because
irq_alloc_domain_generic_chips() has already registered it.

Tested with BeagleBoneBlack Rev C.

Signed-off-by: Milo Kim <milo.kim@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-omap@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/1450687994-12580-1-git-send-email-milo.kim@ti.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irq-omap-intc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/irqchip/irq-omap-intc.c b/drivers/irqchip/irq-omap-intc.c
index 8587d0f..ed25175 100644
--- a/drivers/irqchip/irq-omap-intc.c
+++ b/drivers/irqchip/irq-omap-intc.c
@@ -207,7 +207,6 @@ static int __init omap_alloc_gc_of(struct irq_domain *d, void __iomem *base)
 		ct = gc->chip_types;
 
 		ct->type = IRQ_TYPE_LEVEL_MASK;
-		ct->handler = handle_level_irq;
 
 		ct->chip.irq_ack = omap_mask_ack_irq;
 		ct->chip.irq_mask = irq_gc_mask_disable_reg;

      reply	other threads:[~2015-12-29 11:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21  8:53 [PATCH] irqchip: omap-intc: Remove duplicate setup for IRQ chip type handler Milo Kim
2015-12-21  8:53 ` Milo Kim
2015-12-29 11:05 ` tip-bot for Milo Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-fee48dfcd76b21b9a7117c3014e1345697ff08ec@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=milo.kim@ti.com \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.