From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756522AbcAIQdq (ORCPT ); Sat, 9 Jan 2016 11:33:46 -0500 Received: from terminus.zytor.com ([198.137.202.10]:42049 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756073AbcAIQdn (ORCPT ); Sat, 9 Jan 2016 11:33:43 -0500 Date: Sat, 9 Jan 2016 08:33:01 -0800 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: peterz@infradead.org, dsahern@gmail.com, acme@redhat.com, linux-kernel@vger.kernel.org, mingo@kernel.org, jolsa@redhat.com, hpa@zytor.com, namhyung@kernel.org, adrian.hunter@intel.com, wangnan0@huawei.com, tglx@linutronix.de Reply-To: jolsa@redhat.com, mingo@kernel.org, hpa@zytor.com, peterz@infradead.org, dsahern@gmail.com, acme@redhat.com, linux-kernel@vger.kernel.org, wangnan0@huawei.com, adrian.hunter@intel.com, tglx@linutronix.de, namhyung@kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tests: No need to set attr.sample_freq in the perf time to TSC test Git-Commit-ID: 4f4ba0e6afac4b181471f5f12bd87294bd8807f6 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 4f4ba0e6afac4b181471f5f12bd87294bd8807f6 Gitweb: http://git.kernel.org/tip/4f4ba0e6afac4b181471f5f12bd87294bd8807f6 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 7 Jan 2016 09:54:56 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 7 Jan 2016 11:26:54 -0300 perf tests: No need to set attr.sample_freq in the perf time to TSC test We were asking for a 4kHz sample_freq, making the test fail needlessly when the system reduced /proc/sys/kernel/perf_event_max_sample_rate below that. In this test we only look at the PERF_SAMPLE_TIME fields in PERF_RECORD_ meta events, no need to set sample_freq. Thanks to Namhyung for suggesting that max_sample_rate could be the reason for the test failure, seeing the 'perf test -vv' output I sent. Before: # echo 1000 > /proc/sys/kernel/perf_event_max_sample_rate # perf test TSC 45: Test converting perf time to TSC : FAILED! After: # perf test TSC 45: Test converting perf time to TSC : Ok # cat /proc/sys/kernel/perf_event_max_sample_rate 1000 Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-lcob05qhawkuvsyuu9g1fld5@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/arch/x86/tests/perf-time-to-tsc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/arch/x86/tests/perf-time-to-tsc.c b/tools/perf/arch/x86/tests/perf-time-to-tsc.c index a289aa8..9d29ee2 100644 --- a/tools/perf/arch/x86/tests/perf-time-to-tsc.c +++ b/tools/perf/arch/x86/tests/perf-time-to-tsc.c @@ -41,7 +41,6 @@ int test__perf_time_to_tsc(int subtest __maybe_unused) .mmap_pages = UINT_MAX, .user_freq = UINT_MAX, .user_interval = ULLONG_MAX, - .freq = 4000, .target = { .uses_mmap = true, },