From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756598AbbFSXRF (ORCPT ); Fri, 19 Jun 2015 19:17:05 -0400 Received: from terminus.zytor.com ([198.137.202.10]:52744 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756530AbbFSXQp (ORCPT ); Fri, 19 Jun 2015 19:16:45 -0400 Date: Fri, 19 Jun 2015 16:16:29 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: bp@suse.de, tglx@linutronix.de, eranian@google.com, jolsa@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, namhyung@kernel.org, fweisbec@gmail.com, dsahern@gmail.com, adrian.hunter@intel.com, acme@redhat.com, dzickus@redhat.com Reply-To: hpa@zytor.com, linux-kernel@vger.kernel.org, eranian@google.com, tglx@linutronix.de, bp@suse.de, mingo@kernel.org, jolsa@redhat.com, acme@redhat.com, dzickus@redhat.com, fweisbec@gmail.com, adrian.hunter@intel.com, dsahern@gmail.com, namhyung@kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf top: Replace CTRL+z with 'f' as hotkey for enable/disable events Git-Commit-ID: fbb7997e308064a0ea26fb5435ee5fa69a588dac X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: fbb7997e308064a0ea26fb5435ee5fa69a588dac Gitweb: http://git.kernel.org/tip/fbb7997e308064a0ea26fb5435ee5fa69a588dac Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 19 Jun 2015 16:56:04 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 19 Jun 2015 16:56:04 -0300 perf top: Replace CTRL+z with 'f' as hotkey for enable/disable events I.e. 'freeze'/'unfreeze', this is because CTRL+z has a well known action, i.e. suspend the app, perf needs to follow that convention, that will be done on a separate patch, tho. Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Don Zickus Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Namhyung Kim Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-oedcl6ovohara4koig14ayip@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-top.c | 2 +- tools/perf/ui/browsers/hists.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 72d8a7a..ccf569a 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -591,7 +591,7 @@ static void *display_thread_tui(void *arg) top->min_percent, &top->session->header.env); - if (key != CTRL('z')) + if (key != 'f') break; perf_evlist__toggle_enable(top->evlist); diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 8f7c4d4..764f7ca 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -1736,7 +1736,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, "t Zoom into current Thread\n" "V Verbose (DSO names in callchains, etc)\n" "z Toggle zeroing of samples\n" - "CTRL+z Enable/Disable events\n" + "f Enable/Disable events\n" "/ Filter symbol by name"; if (browser == NULL) @@ -1901,7 +1901,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, /* Fall thru */ case 'q': case CTRL('c'): - case CTRL('z'): + case 'f': goto out_free_stack; default: continue; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/