All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Linus Torvalds <torvalds@osdl.org>, git@vger.kernel.org
Subject: Re: git-rev-list bug?
Date: Fri, 10 Mar 2006 11:01:55 +0000	[thread overview]
Message-ID: <tnx64mmpnq4.fsf@arm.com> (raw)
In-Reply-To: <7vslpqy4u7.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Fri, 10 Mar 2006 02:25:04 -0800")

Junio C Hamano <junkio@cox.net> wrote:
> Junio C Hamano <junkio@cox.net> writes:
>
>> It however has a side effect -- uninteresting commits were never
>> parsed here, but now they get parsed.  I am not sure if there
>> are correctness implications...
>
> Actually there is.  If a merge with an uninteresting side branch
> was the only thing that brought changes to paths we are
> interested in, we do not want TREE_SAME logic to remove other
> parents (i.e. the branches we are interested in) from the merge
> commit.  
>
> So we would need a combination of both, something like this?

I can confirm that it "stg patches" works fine with this patch for
git-rev-list.

Thanks.

-- 
Catalin

  reply	other threads:[~2006-03-10 11:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-08 16:19 git-rev-list bug? Catalin Marinas
2006-03-08 20:16 ` Junio C Hamano
2006-03-10  8:20   ` Junio C Hamano
2006-03-10  9:40     ` Junio C Hamano
2006-03-10  9:59       ` Junio C Hamano
2006-03-10 10:25         ` Junio C Hamano
2006-03-10 11:01           ` Catalin Marinas [this message]
2006-03-10 18:31           ` Linus Torvalds
2006-03-10 22:42             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tnx64mmpnq4.fsf@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.