From: Catalin Marinas <catalin.marinas@arm.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit] How do I get colored diff output?
Date: Fri, 31 Aug 2007 16:14:49 +0100 [thread overview]
Message-ID: <tnxveavviqe.fsf@arm.com> (raw)
In-Reply-To: <fb6sst$6rt$2@sea.gmane.org> (Jakub Narebski's message of "Thu, 30 Aug 2007 18:57:04 +0200")
Jakub Narebski <jnareb@gmail.com> wrote:
> Catalin Marinas wrote:
>
>> I now tried the example stgit.pager option and it looks bad indeed. In
>> the meantime, there is a diffcol.sh script in the contrib directory, I
>> use this instead and it looks much nicer.
>
> That means it should be not removed even though git-diff learned
> --color...
It looks nicer than "filterdiff | colordiff" (and probably pretty
similar to the git-diff --color output).
It shouldn't be removed yet because there is no support in StGIT to
pass these options automatically. Since StGIT uses git-diff-tree/index
directly, always passing the --color option to these tools is not
feasible as they cannot detect whether the output is tty or file. This
functionality is currently handled by the pydoc.pager function.
Using git-diff would require a bit of work as well since StGIT first
captures the output and displays it afterwards via pydoc.pager. We
might change this at some point since GIT now has proper support for
PAGER.
--
Catalin
prev parent reply other threads:[~2007-08-31 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 12:32 [StGit] How do I get colored diff output? Peter Baumann
2007-08-30 13:22 ` Catalin Marinas
2007-08-30 13:59 ` Peter Baumann
2007-08-30 16:57 ` Jakub Narebski
2007-08-31 15:14 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tnxveavviqe.fsf@arm.com \
--to=catalin.marinas@arm.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.