From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcus Sundberg Subject: Re: [PATCH] ip_ct_refresh_optimization.patch Date: 14 Sep 2002 14:52:50 +0200 Sender: netfilter-devel-admin@lists.netfilter.org Message-ID: References: <1031835954.28101.82.camel@tux> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Netfilter-devel Return-path: To: Martin Josefsson In-Reply-To: <1031835954.28101.82.camel@tux> Errors-To: netfilter-devel-admin@lists.netfilter.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: netfilter-devel.vger.kernel.org Martin Josefsson writes: > Yes I know it's broken, I do have a newer version but I havn't committed > it to cvs. I think Patrick Shaaf's solution is a better one and we > should probably go with something like that. Probably yes, but that's no reason to have a completely broken patch which can be fixed by a one-liner in CVS. It should IMHO either be fixed or removed asap. > you can find a few optimisation and other patches over at > http://www.netfilter.org/~gandalf/ > > timer-update2-inc.diff is almost like your patch. I'm using it right now > and it seems to be working fine. That patch is also incorrect, but it works because it updates to often, not to seldom. If the new timeout is one jiffie earlier than the previous timeout your expression will evaluate to 0xffffffff and thus update the timer even though there's no need. The cast is useless btw, because all operands, and thus the result also, are already unsigned long. //Marcus -- ---------------------------------------+-------------------------- Marcus Sundberg | Firewalls with SIP & NAT Firewall Developer, Ingate Systems AB | http://www.ingate.com/