All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernd Kuhls <berndkuhls@hotmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate
Date: Sun, 02 Feb 2014 17:51:43 +0100	[thread overview]
Message-ID: <vl92saxilm.ln2@ID-313208.user.individual.net> (raw)
In-Reply-To: BLU0-SMTP112B1A733C43DA19ABF8DF9D9CE0@phx.gbl

Bernd Kuhls <berndkuhls@hotmail.com> wrote in
news:BLU0-SMTP112B1A733C43DA19ABF8DF9D9CE0 at phx.gbl: 

> -GNUPG_DEPENDENCIES = zlib ncurses
> +GNUPG_DEPENDENCIES = zlib ncurses $(if
> $(BR2_PACKAGE_LIBICONV),libiconv) 

Hi,

this a follow-up for Thomas? question:
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/75233

Today I tested the necessity of my patch without a custom uClibc
configuration file, only with this defconfig applied to a current git 
checkout:

BR2_JLEVEL=8
BR2_ENABLE_DEBUG=y
BR2_OPTIMIZE_2=y
BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_PTHREAD_DEBUG=y
# BR2_UCLIBC_INSTALL_UTILS is not set
BR2_BINUTILS_VERSION_2_23_2=y
BR2_GCC_VERSION_4_8_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_HOST_GDB=y
BR2_PACKAGE_GETTEXT=y
BR2_PACKAGE_LIBICONV=y
BR2_PACKAGE_GNUPG=y

Building these targets in the following order

- toolchain
- libiconv
- gnupg

results in a gpg binary linked to libiconv

$ /home/fli4l/buildroot/output/host/usr/bin/i586-buildroot-linux-uclibc-
readelf -a /home/fli4l/buildroot/output/target/usr/bin/gpg | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libiconv.so.2]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libgcc_s.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.0]

Removing

BR2_PACKAGE_GETTEXT=y
BR2_PACKAGE_LIBICONV=y

from defconfig results in this gpg binary:

/home/fli4l/buildroot/output/host/usr/bin/i586-buildroot-linux-uclibc-
readelf -a /home/fli4l/buildroot/output/target/usr/bin/gpg | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
 0x00000001 (NEEDED)                     Shared library: [libgcc_s.so.1]
 0x00000001 (NEEDED)                     Shared library: [libc.so.0]

I hope this proves why my patches are necessary.

Regards, Bernd

  reply	other threads:[~2014-02-02 16:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30 17:57 [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate Bernd Kuhls
2014-02-02 16:51 ` Bernd Kuhls [this message]
2014-02-04  9:59 ` Arnout Vandecappelle
2014-02-04 10:11   ` Arnout Vandecappelle
2014-02-04 10:25     ` Peter Korsgaard
2014-02-04 10:24   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vl92saxilm.ln2@ID-313208.user.individual.net \
    --to=berndkuhls@hotmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.