From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Tanay Abhra <tanayabh@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH 3/7] add a test for semantic errors in config files
Date: Wed, 23 Jul 2014 21:55:44 +0200 [thread overview]
Message-ID: <vpq38drvohr.fsf@anie.imag.fr> (raw)
In-Reply-To: <1406140978-9472-4-git-send-email-tanayabh@gmail.com> (Tanay Abhra's message of "Wed, 23 Jul 2014 11:42:54 -0700")
Tanay Abhra <tanayabh@gmail.com> writes:
> +test_expect_success 'check line errors for malformed values' '
> + cp .git/config .git/config.old &&
> + test_when_finished "mv .git/config.old .git/config" &&
> + echo "[alias]\n br" >.git/config &&
> + test_expect_code 128 git br 2>result &&
> + grep "fatal: bad config file line 2 in .git/config" result
> +'
> +
The test fails at this point in history. I guess the problem will
disapear once you've put PATCH 2 at the right point in the series.
Another option is to mark the test as test_expect_failure when you
introduce it, and change it to test_expect_success when you fix it
(probably not applicable here, but it's a trick I find elegant).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-23 19:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 18:42 [PATCH 0/7] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-23 18:42 ` [PATCH 1/7] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-23 21:49 ` Junio C Hamano
2014-07-24 13:33 ` Tanay Abhra
2014-07-24 18:31 ` Junio C Hamano
2014-07-24 18:40 ` Tanay Abhra
2014-07-24 18:49 ` Matthieu Moy
2014-07-23 18:42 ` [PATCH 2/7] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-23 19:55 ` Matthieu Moy
2014-07-23 19:58 ` Matthieu Moy
2014-07-23 21:58 ` Junio C Hamano
2014-07-24 6:43 ` Matthieu Moy
2014-07-23 18:42 ` [PATCH 3/7] add a test for semantic errors in config files Tanay Abhra
2014-07-23 19:55 ` Matthieu Moy [this message]
2014-07-23 22:11 ` Junio C Hamano
2014-07-24 13:56 ` Tanay Abhra
2014-07-24 14:05 ` Matthieu Moy
2014-07-24 16:41 ` Junio C Hamano
2014-07-23 18:42 ` [PATCH 4/7] add line number and file name info to `config_set` Tanay Abhra
2014-07-23 22:24 ` Junio C Hamano
2014-07-23 18:42 ` [PATCH 5/7] enforce `xfuncname` precedence over `funcname` Tanay Abhra
2014-07-23 20:05 ` Matthieu Moy
2014-07-23 21:04 ` Eric Sunshine
2014-07-23 22:34 ` Junio C Hamano
2014-07-24 6:39 ` Matthieu Moy
2014-07-24 17:09 ` Junio C Hamano
2014-07-24 18:33 ` Tanay Abhra
2014-07-24 18:47 ` Matthieu Moy
2014-07-24 19:04 ` John Keeping
2014-07-24 19:20 ` Junio C Hamano
2014-07-24 19:29 ` Tanay Abhra
2014-07-24 19:54 ` Junio C Hamano
2014-07-24 21:22 ` Ramsay Jones
2014-07-25 3:16 ` Tanay Abhra
2014-07-25 6:54 ` Matthieu Moy
2014-07-25 17:09 ` Junio C Hamano
2014-07-25 17:45 ` Matthieu Moy
2014-07-25 18:55 ` Junio C Hamano
2014-07-23 18:42 ` [PATCH 6/7] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-23 18:42 ` [PATCH 7/7] Add tests for `git_config_get_string()` Tanay Abhra
2014-07-23 20:08 ` Matthieu Moy
2014-07-23 19:38 ` [PATCH 0/7] Rewrite `git_config()` using config-set API Matthieu Moy
2014-07-23 21:44 ` Junio C Hamano
2014-07-24 15:04 ` Tanay Abhra
2014-07-24 15:39 ` Matthieu Moy
2014-07-24 15:59 ` Tanay Abhra
2014-07-24 16:17 ` Matthieu Moy
2014-07-24 20:03 ` Junio C Hamano
2014-07-24 15:06 ` [PATCH v12 1/2] add `config_set` API for caching config-like files Tanay Abhra
2014-07-24 18:41 ` Junio C Hamano
2014-07-24 15:09 ` [PATCH v12 2/2] test-config: add tests for the config_set API Tanay Abhra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq38drvohr.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.