From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH 3/5] t/t1304: use 'test -r' to test readability rather than looking at mode bits Date: Mon, 15 Mar 2010 18:33:53 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org, Brandon Casey To: Brandon Casey X-From: git-owner@vger.kernel.org Mon Mar 15 18:37:06 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NrEDx-0006cJ-M2 for gcvg-git-2@lo.gmane.org; Mon, 15 Mar 2010 18:37:06 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935320Ab0CORgz (ORCPT ); Mon, 15 Mar 2010 13:36:55 -0400 Received: from imag.imag.fr ([129.88.30.1]:48243 "EHLO imag.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934859Ab0CORgy (ORCPT ); Mon, 15 Mar 2010 13:36:54 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by imag.imag.fr (8.13.8/8.13.8) with ESMTP id o2FHXs5j028297 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 15 Mar 2010 18:33:54 +0100 (CET) Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtp (Exim 4.69) (envelope-from ) id 1NrEAs-0008RR-3l; Mon, 15 Mar 2010 18:33:54 +0100 In-Reply-To: (Brandon Casey's message of "Mon\, 15 Mar 2010 12\:14\:35 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.1.93 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (imag.imag.fr [129.88.30.1]); Mon, 15 Mar 2010 18:33:56 +0100 (CET) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Brandon Casey writes: > - -r--r-----*) > - : happy > - ;; > + test -r "$1" && Maybe it makes sense to ask for -r--?-----* instead, to make sure we don't give the read bit to anyone. But that's not really important since we're protected by the directory's permission anyway. -- Matthieu Moy http://www-verimag.imag.fr/~moy/