From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
remi lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
louis--alexandre stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
remi galan-alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
guillaume pages <guillaume.pages@ensimag.grenoble-inp.fr>,
chriscool@tuxfamily.org, thomasxnguy@gmail.com,
valentinduperray@gmail.com
Subject: Re: [PATCH 3/4] bisect: simplify the add of new bisect terms
Date: Wed, 10 Jun 2015 18:30:21 +0200 [thread overview]
Message-ID: <vpq4mmfv84i.fsf@anie.imag.fr> (raw)
In-Reply-To: <2139695602.323234.1433873829922.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Antoine Delaite's message of "Tue, 9 Jun 2015 20:17:09 +0200 (CEST)")
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr> writes:
>>> +get_terms () {
>>> + if test -s "$GIT_DIR/BISECT_TERMS"
>>> + then
>>> + NAME_BAD="$(sed -n 1p "$GIT_DIR/BISECT_TERMS")"
>>> + NAME_GOOD="$(sed -n 2p "$GIT_DIR/BISECT_TERMS")"
>>
>>It is sad that we need to open the file twice. Can't we do
>>something using "read" perhaps?
>
> The cost of it is quite low and we see directly what we meant. We didn't
> found a pretty way to read two lines with read.
Should be stg like:
{
read good
read bad
} <"$GIT_DIR/BISECT_TERMS"
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-10 16:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 20:22 [PATCH 1/4] bisect : correction of typo Antoine Delaite
2015-06-08 20:22 ` [PATCH 2/4] bisect: replace hardcoded "bad|good" by variables Antoine Delaite
2015-06-08 20:30 ` Junio C Hamano
2015-06-09 6:45 ` Matthieu Moy
2015-06-09 8:12 ` Christian Couder
2015-06-09 12:39 ` Matthieu Moy
2015-06-09 19:18 ` Junio C Hamano
2015-06-08 20:22 ` [PATCH 3/4] bisect: simplify the add of new bisect terms Antoine Delaite
2015-06-08 20:42 ` Junio C Hamano
2015-06-09 18:17 ` Antoine Delaite
2015-06-10 16:30 ` Matthieu Moy [this message]
2015-06-09 7:01 ` Matthieu Moy
2015-06-09 8:39 ` Christian Couder
2015-06-09 20:17 ` Louis-Alexandre Stuber
2015-06-10 0:39 ` Junio C Hamano
2015-06-10 7:15 ` Louis-Alexandre Stuber
2015-06-10 8:03 ` Matthieu Moy
2015-06-10 9:41 ` Louis-Alexandre Stuber
2015-06-10 15:24 ` Matthieu Moy
2015-06-10 15:10 ` Junio C Hamano
2015-06-10 15:25 ` Matthieu Moy
2015-06-10 16:11 ` Junio C Hamano
2015-06-08 20:22 ` [PATCH 4/4] bisect: add the terms old/new Antoine Delaite
2015-06-08 21:21 ` Junio C Hamano
[not found] <1183699596.323718.1433875699237.JavaMail.zimbra@ensimag.grenoble-inp.fr>
2015-06-10 7:09 ` [PATCH 3/4] bisect: simplify the add of new bisect terms Antoine Delaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq4mmfv84i.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=thomasxnguy@gmail.com \
--cc=valentinduperray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.