From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>, Git <git@vger.kernel.org>,
"Christian Couder" <christian.couder@gmail.com>
Subject: Re: [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs
Date: Wed, 08 Jul 2015 17:46:57 +0200 [thread overview]
Message-ID: <vpq615ud53i.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAOLa=ZQ=Mjx-L8Xn9kA86b7nv_bF24Mje1rU-Rmcq4kMqp8qMg@mail.gmail.com> (Karthik Nayak's message of "Wed, 8 Jul 2015 19:29:58 +0530")
Karthik Nayak <karthik.188@gmail.com> writes:
> On Wed, Jul 8, 2015 at 2:37 PM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Torsten Bögershausen <tboegi@web.de> writes:
>>
>>> Could we have a tweak for people without gpg?
>>
>> I guess we need stg like
>>
>> if ! test_have_prereq GPG; then
>> skip_all='skipping for-each-ref tests, gpg not available'
>> test_done
>> fi
>>
>> since we need GPG in the setup test and almost all other tests will rely
>> on it.
>>
>
> Does this need to be there? I see a lot of test files which need GPG, and since
> this test file contains tests which rely on it, without it, it would
> be kinda useless
> anyways?
In many cases, the tests look like
. lib-gpg.sh
test_expect_success 'test that does not use GPG' '
...
'
test_expect_success GPG 'test that does use GPG' '
...
'
so you can't decide in lib-gpg.sh that you'll skip all tests, because
you would skip some tests that could be ran without gpg.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-07-08 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 16:05 [PATCH v8 00/11] add options to for-each-ref Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 02/11] tag: libify parse_opt_points_at() Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 03/11] ref-filter: implement '--points-at' option Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 04/11] for-each-ref: add " Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 05/11] ref-filter: add parse_opt_merge_filter() Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 06/11] ref-filter: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 07/11] for-each-ref: add " Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 08/11] parse-option: rename parse_opt_with_commit() Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 09/11] parse-options.h: add macros for '--contains' option Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 10/11] ref-filter: implement " Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 11/11] for-each-ref: add " Karthik Nayak
2015-07-08 8:09 ` [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs Torsten Bögershausen
2015-07-08 9:07 ` Matthieu Moy
2015-07-08 13:59 ` Karthik Nayak
2015-07-08 15:46 ` Matthieu Moy [this message]
2015-07-09 5:52 ` Karthik Nayak
2015-07-09 6:03 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq615ud53i.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.