From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: git@vger.kernel.org, j.sixt@viscovery.net,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH v2 2/3] submodule: introduce --[no-]display-comment-char
Date: Thu, 29 Aug 2013 09:04:39 +0200 [thread overview]
Message-ID: <vpq7gf53rlk.fsf@anie.imag.fr> (raw)
In-Reply-To: <521E6674.1010201@web.de> (Jens Lehmann's message of "Wed, 28 Aug 2013 23:07:00 +0200")
Jens Lehmann <Jens.Lehmann@web.de> writes:
> But I'm not terribly happy about having the --for-status option in the
> submodule script in the first place, as I believe it should rather be
> handled by wt-status.c itself (reading the output of submodule summary
> using the start_command()/finish_command() combo instead of the simple
> run_command() currently used and prepending the comment char by using
> status_printf() & friends for each line).
I went the --for-status way because it's easier to do this in shell than
in C. But I'm close to be convinced that implementing this on the
wt-status.c side is better. I'll try a re-roll doing this when I get
time.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-08-29 7:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 8:32 [RFC/PATCH] status: introduce status.displayCommentChar to disable display of # Matthieu Moy
2013-08-28 11:03 ` Johannes Sixt
2013-08-28 12:43 ` Matthieu Moy
2013-08-28 12:47 ` [RFC/PATCH v2 1/3] builtin/stripspace.c: fix broken indentation Matthieu Moy
2013-08-28 12:47 ` [RFC/PATCH v2 2/3] submodule: introduce --[no-]display-comment-char Matthieu Moy
2013-08-28 21:07 ` Jens Lehmann
2013-08-29 7:04 ` Matthieu Moy [this message]
2013-08-28 12:47 ` [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of # Matthieu Moy
2013-08-28 20:05 ` Junio C Hamano
2013-08-28 20:10 ` Junio C Hamano
2013-08-28 20:18 ` Jeff King
2013-08-28 21:39 ` Junio C Hamano
2013-08-28 21:59 ` David Aguilar
2013-08-28 22:41 ` Junio C Hamano
2013-08-29 6:58 ` Matthieu Moy
2013-08-31 0:00 ` brian m. carlson
2013-08-28 20:59 ` Matthieu Moy
2013-08-28 21:53 ` Junio C Hamano
2013-08-28 21:50 ` Junio C Hamano
2013-08-28 23:13 ` Jonathan Nieder
2013-08-29 6:50 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq7gf53rlk.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.