From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: "David Rydh" <dary@math.berkeley.edu>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
"Johannes Sixt" <j6t@kdbg.org>
Subject: Re: [PATCH] git-mv: Fix error with multiple sources.
Date: Fri, 22 Jan 2010 08:03:47 +0100 [thread overview]
Message-ID: <vpq7hrapqng.fsf@bauges.imag.fr> (raw)
In-Reply-To: <718290.769818367-sendEmail@darysmbp> (David Rydh's message of "Thu\, 21 Jan 2010 12\:39\:41 -0800")
"David Rydh" <dary@math.berkeley.edu> writes:
> if (!is_absolute_path(given_config_file) && prefix)
> - config_exclusive_filename = prefix_filename(prefix,
> + config_exclusive_filename = xstrdup(prefix_filename(prefix,
> strlen(prefix),
> - argv[2]);
> + argv[2]));
Broken indentation on the last two lines.
Other than that, you use strdup without free-ing the result. Probably
not so serious, but it may be cleaner to actually call free, or to
explain why you don't (in commit message).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-01-22 7:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 20:39 [PATCH] git-mv: Fix error with multiple sources David Rydh
2010-01-22 5:57 ` Junio C Hamano
2010-01-22 16:41 ` David Rydh
2010-01-22 6:17 ` Junio C Hamano
2010-01-22 16:49 ` David Rydh
2010-01-22 6:24 ` Junio C Hamano
[not found] ` <7vr5pi8x6z.fsf@alter.siamese.dyndns.org>
2010-01-22 17:30 ` David Rydh
2010-01-22 18:34 ` Johannes Sixt
2010-01-22 7:03 ` Matthieu Moy [this message]
2010-01-22 7:29 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq7hrapqng.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=dary@math.berkeley.edu \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.