From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH v17 14/14] tag.c: implement '--merged' and '--no-merged' options Date: Fri, 18 Sep 2015 17:19:42 +0200 Message-ID: References: <1441900110-4015-1-git-send-email-Karthik.188@gmail.com> <1441902169-9891-3-git-send-email-Karthik.188@gmail.com> <20150917213619.GI17201@serenity.lan> <20150918084208.GJ17201@serenity.lan> Mime-Version: 1.0 Content-Type: text/plain Cc: John Keeping , Junio C Hamano , Git , Christian Couder To: Karthik Nayak X-From: git-owner@vger.kernel.org Fri Sep 18 17:20:35 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZcxSk-0002BK-43 for gcvg-git-2@plane.gmane.org; Fri, 18 Sep 2015 17:20:34 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754619AbbIRPUV (ORCPT ); Fri, 18 Sep 2015 11:20:21 -0400 Received: from mx1.imag.fr ([129.88.30.5]:50235 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754417AbbIRPUT (ORCPT ); Fri, 18 Sep 2015 11:20:19 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id t8IFJeHm027229 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 18 Sep 2015 17:19:40 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t8IFJgYN015278; Fri, 18 Sep 2015 17:19:42 +0200 In-Reply-To: (Karthik Nayak's message of "Fri, 18 Sep 2015 20:40:35 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Fri, 18 Sep 2015 17:19:40 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t8IFJeHm027229 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1443194381.27905@zJAK2xGIgd/c+TzDhzYllQ Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Karthik Nayak writes: > Not sure this is much of a problem with regards to "--[no-]merged" > I mean isn't the square brackets self-explanatory? Well, usually --no-foo means "cancel the effect of --foo", ie. "git command --foo --no-foo" is equivalent to "git command". Here, --no-merged=some-ref does not _cancel_ the effect but introduce a new behavior that was not the default. So it may make sense to explain this more clearly. -- Matthieu Moy http://www-verimag.imag.fr/~moy/