From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org,
Piotr Krukowiecki <piotr.krukowiecki.news@gmail.com>,
Jay Soffian <jaysoffian@gmail.com>, Miles Bader <miles@gnu.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Philip Oakley <philipoakley@iee.org>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Scott Chacon <schacon@gmail.com>
Subject: Re: [PATCH 1/2] Add proper 'stage' command
Date: Thu, 29 Aug 2013 20:38:41 +0200 [thread overview]
Message-ID: <vpq8uzks5ou.fsf@anie.imag.fr> (raw)
In-Reply-To: <1377799744-5201-2-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Thu, 29 Aug 2013 13:09:03 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> +COMMANDS
> +--------
> +
> +With no arguments, it's a synonym for linkgit:git-add[1].
This would not be very useful since "git add" errors out when called
without arguments ;-).
The accurate description of your code would be closer to "When the first
argument is not a subcommand, it's a synonym for linkgit:git-add[1].".
I'm not sure I like it, as it creates ambiguities (e.g. need to spell
"git stage -- diff" to add a file called "diff". Not a strong objection
though, as we already have refs Vs filename ambiguities in many places.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-08-29 18:38 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 18:01 Officially start moving to the term 'staging area' Felipe Contreras
2013-08-29 18:09 ` [PATCH 0/2] stage: proper 'stage' command Felipe Contreras
2013-08-29 18:09 ` [PATCH 1/2] Add " Felipe Contreras
2013-08-29 18:38 ` Matthieu Moy [this message]
2013-08-29 18:47 ` Felipe Contreras
2013-08-29 18:09 ` [PATCH 2/2] stage: add edit command Felipe Contreras
2013-08-29 18:35 ` Matthieu Moy
2013-08-29 18:42 ` Felipe Contreras
2013-08-29 18:14 ` [PATCH 0/9] Add --stage and --work options Felipe Contreras
2013-08-29 18:14 ` [PATCH 1/9] diff: document --staged Felipe Contreras
2013-08-29 18:14 ` [PATCH 2/9] grep: add --staged option Felipe Contreras
2013-08-29 18:14 ` [PATCH 3/9] rm: " Felipe Contreras
2013-08-29 18:14 ` [PATCH 4/9] stash: add --stage option to save Felipe Contreras
2013-08-29 18:39 ` Matthieu Moy
2013-08-29 18:14 ` [PATCH 5/9] stash: add --stage to pop and apply Felipe Contreras
2013-08-29 18:14 ` [PATCH 6/9] submodule: add --staged options Felipe Contreras
2013-08-29 18:14 ` [PATCH 7/9] apply: add --stage option Felipe Contreras
2013-08-29 18:14 ` [PATCH 8/9] apply: add --work, --no-work options Felipe Contreras
2013-08-29 18:14 ` [PATCH 9/9] completion: update --staged options Felipe Contreras
2013-08-29 18:19 ` [PATCH 0/3] reset: refactor into --stage and --work Felipe Contreras
2013-08-29 18:19 ` [PATCH 1/3] reset: add --stage and --work options Felipe Contreras
[not found] ` <CALkWK0=P0xZAk95Jmw9mRUCwPQP7NmVHsuPaWNg+D2v3wP9=-w@mail.gmail.com>
2013-09-08 22:55 ` Felipe Contreras
2013-09-09 0:15 ` Ramkumar Ramachandra
2013-09-09 0:39 ` Felipe Contreras
2013-08-29 18:19 ` [PATCH 2/3] reset: allow --keep with --stage Felipe Contreras
2013-08-29 18:19 ` [PATCH 3/3] completion: update 'git reset' new stage options Felipe Contreras
2013-08-29 18:37 ` Officially start moving to the term 'staging area' Junio C Hamano
2013-08-29 19:57 ` Felipe Contreras
2013-08-30 19:11 ` Felipe Contreras
2013-08-30 20:40 ` Felipe Contreras
2013-08-30 20:42 ` Felipe Contreras
2013-08-30 20:28 ` Felipe Contreras
2013-08-29 21:55 ` Drew Northup
2013-08-29 22:10 ` Felipe Contreras
2013-09-04 4:45 ` Drew Northup
2013-09-08 2:09 ` Felipe Contreras
2013-08-30 5:16 ` Piotr Krukowiecki
2013-09-04 4:23 ` Drew Northup
2013-09-04 7:13 ` Piotr Krukowiecki
2013-09-04 13:36 ` Drew Northup
2013-09-08 1:27 ` Felipe Contreras
2013-09-08 1:18 ` Felipe Contreras
2013-09-08 1:33 ` Felipe Contreras
2013-09-08 7:49 ` Philip Oakley
2013-09-08 9:27 ` Felipe Contreras
2013-08-29 18:50 ` Matthieu Moy
2013-08-29 18:57 ` Felipe Contreras
2013-08-29 19:15 ` Matthieu Moy
2013-08-29 19:21 ` Matthieu Moy
2013-08-29 20:03 ` René Scharfe
2013-08-29 20:36 ` Felipe Contreras
2013-08-31 7:46 ` René Scharfe
2013-08-31 7:53 ` Felipe Contreras
2013-09-01 3:46 ` David Aguilar
2013-08-29 21:03 ` Matthieu Moy
2013-09-04 6:08 ` William Swanson
2013-09-06 15:45 ` Ping Yin
2013-09-06 17:14 ` Hilco Wijbenga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq8uzks5ou.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=jrnieder@gmail.com \
--cc=miles@gnu.org \
--cc=philipoakley@iee.org \
--cc=piotr.krukowiecki.news@gmail.com \
--cc=schacon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.