From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Antoine Queru <antoine.queru@ensimag.grenoble-inp.fr>
Cc: git@vger.kernel.org, william.duclot@ensimag.grenoble-inp.fr,
simon.rabourg@ensimag.grenoble-inp.fr,
francois.beutin@ensimag.grenoble-inp.fr, gitster@pobox.com,
peff@peff.net, sunshine@sunshineco.com
Subject: Re: [PATCH v5] upload-pack.c: use parse-options API
Date: Mon, 30 May 2016 17:06:31 +0200 [thread overview]
Message-ID: <vpqa8j77fgo.fsf@anie.imag.fr> (raw)
In-Reply-To: <20160530145347.15643-1-antoine.queru@ensimag.grenoble-inp.fr> (Antoine Queru's message of "Mon, 30 May 2016 16:53:47 +0200")
Antoine Queru <antoine.queru@ensimag.grenoble-inp.fr> writes:
> From: Antoine Queru <Antoine.Queru@ensimag.grenoble-inp.fr>
[ Insert here the sentence I've been repeating a lot lately about this
useless From ;-) ]
> Documentation/git-upload-pack.txt | 16 +++++++++--
> upload-pack.c | 59 +++++++++++++++++----------------------
> 2 files changed, 38 insertions(+), 37 deletions(-)
The patch contains a few whitespace errors:
Documentation/git-upload-pack.txt:41: space before tab in indent.
+ immediately. This fits with the HTTP GET request model, where
Documentation/git-upload-pack.txt:42: space before tab in indent.
+ no request content is received but a response must be produced.
upload-pack.c:846: trailing whitespace.
+
You should notice them immediately if you use "git add -p" (big red
warning in the patch hunk), and you can see all of them with "git diff
--check" or "git show --check".
Not sure if it deserves a reroll. Junio?
Other than that, the patch is now
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-05-30 15:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:40 [PATCH] upload-pack.c: use of parse-options API Antoine Queru
2016-05-18 18:08 ` Jeff King
2016-05-19 10:10 ` Antoine Queru
2016-05-19 11:57 ` Jeff King
2016-05-19 14:36 ` Matthieu Moy
2016-05-19 15:39 ` [PATCH v2] " Antoine Queru
2016-05-19 16:10 ` Matthieu Moy
2016-05-19 16:46 ` Junio C Hamano
2016-05-20 6:55 ` Matthieu Moy
2016-05-19 16:58 ` Junio C Hamano
2016-05-20 6:53 ` Matthieu Moy
2016-05-20 16:52 ` Junio C Hamano
2016-05-23 13:02 ` [PATCH v3] " Antoine Queru
2016-05-23 18:03 ` Matthieu Moy
2016-05-27 14:16 ` [PATCH v4] " Antoine Queru
2016-05-27 14:52 ` Matthieu Moy
2016-05-27 16:59 ` Eric Sunshine
2016-05-30 14:27 ` Antoine Queru
2016-05-30 14:53 ` [PATCH v5] upload-pack.c: use " Antoine Queru
2016-05-30 15:06 ` Matthieu Moy [this message]
2016-05-30 19:26 ` Junio C Hamano
2016-05-31 9:53 ` Antoine Queru
2016-05-31 11:27 ` Matthieu Moy
2016-05-31 17:16 ` Junio C Hamano
2016-06-01 15:49 ` Antoine Queru
2016-05-31 9:57 ` [PATCH v6] " Antoine Queru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqa8j77fgo.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=antoine.queru@ensimag.grenoble-inp.fr \
--cc=francois.beutin@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=simon.rabourg@ensimag.grenoble-inp.fr \
--cc=sunshine@sunshineco.com \
--cc=william.duclot@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.