From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, sbeller@google.com, peff@peff.net,
christian.couder@gmail.com, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH 3/3] rebase: turn git-rebase--*.sh into separate programs
Date: Wed, 17 Feb 2016 15:05:18 +0100 [thread overview]
Message-ID: <vpqa8mzjuu9.fsf@anie.imag.fr> (raw)
In-Reply-To: <1455716201-29784-4-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Wed, 17 Feb 2016 20:36:41 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> + git_quiet=$GIT_QUIET
> + git_reflog_action=$GIT_REFLOG_ACTION
> + export GIT_PAGER
> + # these are for write_basic_state()
> + export allow_rerere_autoupdate gpg_sign_opt head_name onto
> + export orig_head state_dir strategy strategy_opts verbose
> + # common variables
> + export action git_reflog_action git_quiet keep_empty
> + export rebase_root restrict_revision revisions upstream
> + # git-rebase--am specific
> + export git_am_opt
> + # git-rebase--interactive specific
> + export autosquash cmd force_rebase onto_name preserve_merges
> + export squash_onto switch_to
> +
> + exec git-rebase--$type
This is a good first step, but we may later want to turn these
environment variables into command-line options for the helpers. Or not.
On overall, the series looks good to me, but I don't have time for a
detailed review.
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-02-17 14:05 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 9:31 GSoC 2016: applications open, deadline = Fri, 19/2 Matthieu Moy
2016-02-10 11:09 ` Johannes Schindelin
2016-02-10 17:44 ` Stefan Beller
2016-02-11 8:36 ` Christian Couder
2016-02-12 7:10 ` Matthieu Moy
2016-02-12 8:29 ` Lars Schneider
2016-02-12 9:11 ` Matthieu Moy
2016-02-12 13:04 ` Jeff King
2016-02-12 13:11 ` Jeff King
2016-02-13 11:21 ` Matthieu Moy
2016-02-16 18:10 ` Stefan Beller
2016-02-17 10:34 ` Matthieu Moy
2016-02-17 10:45 ` Duy Nguyen
2016-02-17 13:36 ` [PATCH 0/3] Turn git-rebase--*.sh to external helpers Nguyễn Thái Ngọc Duy
2016-02-17 13:36 ` [PATCH 1/3] rebase: move common functions to rebase--lib.sh Nguyễn Thái Ngọc Duy
2016-02-17 13:36 ` [PATCH 2/3] rebase: move cleanup code to exit_rebase() Nguyễn Thái Ngọc Duy
2016-02-17 14:03 ` Matthieu Moy
2016-02-17 13:36 ` [PATCH 3/3] rebase: turn git-rebase--*.sh into separate programs Nguyễn Thái Ngọc Duy
2016-02-17 14:05 ` Matthieu Moy [this message]
2016-02-17 14:22 ` [PATCH 0/3] Turn git-rebase--*.sh to external helpers Johannes Schindelin
2016-02-17 14:40 ` Duy Nguyen
2016-02-17 13:09 ` GSoC 2016: applications open, deadline = Fri, 19/2 Johannes Schindelin
2016-02-17 16:04 ` Christian Couder
2016-02-22 9:28 ` Duy Nguyen
2016-02-22 10:22 ` Matthieu Moy
2016-02-22 21:42 ` Jeff King
2016-02-22 21:56 ` Junio C Hamano
2016-02-22 22:02 ` Jeff King
2016-02-23 13:13 ` Matthieu Moy
2016-02-24 10:52 ` Jeff King
2016-02-17 17:24 ` Thomas Gummerer
2016-02-17 18:32 ` Lars Schneider
2016-02-17 18:58 ` Matthieu Moy
2016-02-17 19:03 ` Junio C Hamano
2016-02-17 20:21 ` Matthieu Moy
2016-02-17 20:45 ` Jeff King
2016-02-17 21:33 ` Junio C Hamano
2016-02-18 9:38 ` Carlos Martín Nieto
2016-02-19 8:06 ` GSoC 2016: applications open, libgit2 and git.git Matthieu Moy
2016-02-19 9:46 ` Carlos Martín Nieto
2016-02-29 21:01 ` Git has been accepted as a GSoC 2016 mentor organization! Matthieu Moy
2016-03-08 22:46 ` Jeff King
2016-03-08 23:01 ` Junio C Hamano
2016-03-08 23:03 ` Jeff King
2016-03-09 9:55 ` Matthieu Moy
2016-03-09 14:08 ` Jeff King
2016-03-09 13:50 ` Johannes Schindelin
2016-03-09 19:34 ` Jeff King
2016-02-19 8:09 ` GSoC 2016: applications open, deadline = now => submission Matthieu Moy
2016-02-19 8:18 ` Jeff King
2016-02-19 9:10 ` GSoC 2016: applications open, deadline = now => submitted Matthieu Moy
2016-02-19 11:37 ` Jeff King
2016-02-18 8:41 ` GSoC 2016: applications open, deadline = Fri, 19/2 Lars Schneider
2016-02-18 18:38 ` Stefan Beller
2016-02-18 19:13 ` Junio C Hamano
2016-02-19 7:34 ` Matthieu Moy
2016-02-19 20:35 ` Junio C Hamano
2016-02-20 9:28 ` Johannes Schindelin
2016-02-19 9:23 ` Lars Schneider
2016-02-19 12:49 ` Matthieu Moy
2016-02-19 20:37 ` Junio C Hamano
2016-02-19 11:46 ` Thomas Gummerer
2016-02-19 3:09 ` Duy Nguyen
2016-02-19 3:20 ` Junio C Hamano
2016-02-19 3:29 ` Duy Nguyen
2016-02-19 7:17 ` Matthieu Moy
2016-02-19 9:41 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqa8mzjuu9.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.