From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 10/10] t/t9001-send-email.sh: get rid of unnecessary backquotes
Date: Fri, 08 Jan 2016 15:52:12 +0100 [thread overview]
Message-ID: <vpqa8ogdsyr.fsf@anie.imag.fr> (raw)
In-Reply-To: <1452251188-12939-11-git-send-email-gitter.spiros@gmail.com> (Elia Pinto's message of "Fri, 8 Jan 2016 12:06:28 +0100")
Elia Pinto <gitter.spiros@gmail.com> writes:
> Instead of making the shell expand 00* and invoke 'echo' with it,
> and then capturing its output as command substitution, just use
> the result of expanding 00* directly.
This is not actually how it happens. cover=`echo *` expands the * before
the assignment to $cover, while cover="*" assigns a litteral * to
$cover.
Then, when you use $cover, the variable is expanded to * and then it is
expanded to filenames here:
> mv $cover cover-to-edit.patch &&
On the other hand, this instance of $cover is quoted, hence the
*-expansion won't happen:
> perl -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch >"$cover" &&
So, I believe this patch is not correct.
OTOH, patches 1 to 9 look good to me.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-01-08 14:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 11:06 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2016-01-08 11:06 ` [PATCH 01/10] t/t7103-reset-bare.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 02/10] t/t7406-submodule-update.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 03/10] t/t7408-submodule-reference.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 04/10] t/t7504-commit-msg-hook.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 05/10] t/t7505-prepare-commit-msg-hook.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 06/10] t/t7602-merge-octopus-many.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 07/10] t/t7700-repack.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 08/10] t/t8003-blame-corner-cases.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 09/10] t/t9001-send-email.sh: " Elia Pinto
2016-01-08 11:06 ` [PATCH 10/10] t/t9001-send-email.sh: get rid of unnecessary backquotes Elia Pinto
2016-01-08 14:52 ` Matthieu Moy [this message]
2016-01-08 18:12 ` Junio C Hamano
2016-01-08 22:29 ` Elia Pinto
2016-01-08 22:37 ` Junio C Hamano
2016-01-08 23:19 ` Elia Pinto
2016-01-08 20:07 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqa8ogdsyr.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.