All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Damien Robert <damien.olivier.robert+gmane@gmail.com>,
	git@vger.kernel.org
Subject: Re: Remove old forgotten command: whatchanged
Date: Fri, 09 Aug 2013 10:29:28 +0200	[thread overview]
Message-ID: <vpqbo57clnb.fsf@anie.imag.fr> (raw)
In-Reply-To: <7v1u649e5m.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 08 Aug 2013 12:27:17 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> It is meant to teach them "if you want to do your own 'git log', you
> can do so with 'rev-list' piped to 'diff-tree --stdin'".  Changing
> 'whatchanged' to 'log' in the latter statement is an improvement,
> but dropping 'can be done by combining rev-list and diff-tree' goes
> against the objective of the whole document.

Then, we can keep the "In fact, together with the 'git rev-list'
program ..." sentence, but drop "A trivial (but very useful)
script ...", which is both technically incorrect (whatchanged is not a
script anymore) and misleading because it advertises whatchanged.

That would look like this:

diff --git a/Documentation/git.txt b/Documentation/git.txt
index 3bdd56e..486a58b 100644
--- a/Documentation/git.txt
+++ b/Documentation/git.txt
@@ -818,7 +818,7 @@ for further details.
 'GIT_FLUSH'::
        If this environment variable is set to "1", then commands such
        as 'git blame' (in incremental mode), 'git rev-list', 'git log',
-       'git check-attr', 'git check-ignore', and 'git whatchanged' will
+       'git check-attr', and 'git check-ignore' will
        force a flush of the output stream after each record have been
        flushed. If this
        variable is set to "0", the output of these commands will be done
diff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt
index f538a87..8e53560 100644
--- a/Documentation/gitcore-tutorial.txt
+++ b/Documentation/gitcore-tutorial.txt
@@ -534,9 +534,8 @@ all, but just show the actual commit message.
 
 In fact, together with the 'git rev-list' program (which generates a
 list of revisions), 'git diff-tree' ends up being a veritable fount of
-changes. A trivial (but very useful) script called 'git whatchanged' is
-included with Git which does exactly this, and shows a log of recent
-activities.
+changes. The porcelain command 'git log' can also be used to display
+changes introduced by some commits.
 
 To see the whole history of our pitiful little git-tutorial project, you
 can do
@@ -546,11 +545,10 @@ $ git log
 ----------------
 
 which shows just the log messages, or if we want to see the log together
-with the associated patches use the more complex (and much more
-powerful)
+with the associated patches, use the `--patch` option:
 
 ----------------
-$ git whatchanged -p
+$ git log -p
 ----------------
 
 and you will see exactly what has changed in the repository over its

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2013-08-09  8:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 16:00 Remove old forgotten command: whatchanged Ramkumar Ramachandra
2013-08-07 16:51 ` Stefan Beller
2013-08-07 17:50   ` Junio C Hamano
2013-08-07 21:50     ` Stefan Beller
2013-08-08  6:39       ` Junio C Hamano
2013-08-08  4:30     ` Ramkumar Ramachandra
2013-08-08 15:03       ` Matthieu Moy
2013-08-08 15:13         ` Ramkumar Ramachandra
2013-08-08 15:24           ` Matthieu Moy
2013-08-08 17:23             ` Junio C Hamano
2013-08-09 20:01               ` [PATCH] whatchanged: document its historical nature Junio C Hamano
2013-08-09 20:14                 ` John Keeping
2013-08-09 20:57                   ` Junio C Hamano
2013-08-12  7:50                     ` John Keeping
2013-08-13 15:56                       ` Junio C Hamano
2013-08-10  7:04                 ` Ramkumar Ramachandra
2013-08-08 17:51         ` Remove old forgotten command: whatchanged Damien Robert
2013-08-08 18:05           ` Ramkumar Ramachandra
2013-08-08 18:06           ` Matthieu Moy
2013-08-08 19:09             ` John Keeping
2013-08-08 19:27             ` Junio C Hamano
2013-08-09  8:29               ` Matthieu Moy [this message]
2013-08-09 17:28                 ` Junio C Hamano
2013-08-13  7:58                   ` Matthieu Moy
2013-08-13 16:00                     ` Junio C Hamano
2013-08-08 19:19           ` Junio C Hamano
2013-08-09  0:04             ` Damien Robert
2013-08-09  0:11               ` Junio C Hamano
2013-08-07 18:01 ` Kyle J. McKay
2013-08-07 18:31   ` John Keeping
2013-08-07 18:48     ` Kyle J. McKay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqbo57clnb.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=damien.olivier.robert+gmane@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.