From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config() Date: Mon, 17 Mar 2014 11:01:15 +0100 Message-ID: References: <1395050104-19152-1-git-send-email-moxobukob@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org To: Aleksey Mokhovikov X-From: git-owner@vger.kernel.org Mon Mar 17 11:01:27 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WPUMI-0008LY-JQ for gcvg-git-2@plane.gmane.org; Mon, 17 Mar 2014 11:01:26 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932679AbaCQKBV (ORCPT ); Mon, 17 Mar 2014 06:01:21 -0400 Received: from mx1.imag.fr ([129.88.30.5]:33492 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932318AbaCQKBV (ORCPT ); Mon, 17 Mar 2014 06:01:21 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id s2HA1E1o031040 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 17 Mar 2014 11:01:14 +0100 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id s2HA1F1m026429; Mon, 17 Mar 2014 11:01:15 +0100 In-Reply-To: <1395050104-19152-1-git-send-email-moxobukob@gmail.com> (Aleksey Mokhovikov's message of "Mon, 17 Mar 2014 16:55:04 +0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Mon, 17 Mar 2014 11:01:14 +0100 (CET) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: s2HA1E1o031040 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1395655276.94132@CiJ76AKUxwfsRwAV/Yvisg Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, Aleksey Mokhovikov writes: > This is a milliproject from git google summer of code page. The > current code that selects the output message is quite easy to > understand. So I tried to improve it by removing nested conditions and > code duplication. The output string is generated by selecting the > proper parts of the message and concatenating them the into one > template string. Please, read the threads for other submissions for this microproject. Most remarks done there also apply for your case. See for example: http://thread.gmane.org/gmane.comp.version-control.git/244210 -- Matthieu Moy http://www-verimag.imag.fr/~moy/