From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH/RFCv3 1/2] git-rebase -i: add command "drop" to remove a commit Date: Tue, 02 Jun 2015 16:17:52 +0200 Message-ID: References: <1433252180-25591-1-git-send-email-remi.galan-alfonso@ensimag.grenoble-inp.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Git List , Remi Lespinet , Guillaume Pages , Louis-Alexandre Stuber , Antoine Delaite , Junio C Hamano , Eric Sunshine To: Galan =?iso-8859-1?Q?R=E9mi?= X-From: git-owner@vger.kernel.org Tue Jun 02 16:18:09 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yzn14-0005JH-Cy for gcvg-git-2@plane.gmane.org; Tue, 02 Jun 2015 16:18:06 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759310AbbFBOSC convert rfc822-to-quoted-printable (ORCPT ); Tue, 2 Jun 2015 10:18:02 -0400 Received: from mx2.imag.fr ([129.88.30.17]:38595 "EHLO rominette.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758633AbbFBOSA (ORCPT ); Tue, 2 Jun 2015 10:18:00 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by rominette.imag.fr (8.13.8/8.13.8) with ESMTP id t52EHpeZ032193 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Jun 2015 16:17:51 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t52EHqO8013301; Tue, 2 Jun 2015 16:17:52 +0200 In-Reply-To: <1433252180-25591-1-git-send-email-remi.galan-alfonso@ensimag.grenoble-inp.fr> ("Galan \=\?iso-8859-1\?Q\?R\=E9mi\=22's\?\= message of "Tue, 2 Jun 2015 15:36:19 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (rominette.imag.fr [129.88.30.17]); Tue, 02 Jun 2015 16:17:51 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t52EHpeZ032193 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1433859472.02806@Xki3Yi5z30rxfhTL1pNUlg Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Galan R=E9mi writes: > +test_expect_success 'drop' ' Please, be more descriptive in the first argument of test_expect_success. It's usually a good thing to say not only what the test stresses but also what the expected behavior is. test_expect_success 'drop actually drops the lines' ' ... ' ? --=20 Matthieu Moy http://www-verimag.imag.fr/~moy/