From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org, jrnieder@gmail.com
Subject: Re: [PATCH 10/19] git-submodule.sh: convert test -a/-o to && and ||
Date: Tue, 20 May 2014 16:07:47 +0200 [thread overview]
Message-ID: <vpqegzo4k7g.fsf@anie.imag.fr> (raw)
In-Reply-To: <1400593832-6510-11-git-send-email-gitter.spiros@gmail.com> (Elia Pinto's message of "Tue, 20 May 2014 06:50:23 -0700")
Elia Pinto <gitter.spiros@gmail.com> writes:
> - test $status = D -o $status = T && echo "$sm_path" && continue
> + {
> + test "$status" = D ||
> + test "$status" = T
> + } &&
> + echo "$sm_path"
> + && continue
We usually write the && at the end of the line, hence that would be
echo "$sm_path" &&
continue
(shouldn't block the patch, but you may change if you need to resend)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-05-20 14:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 13:50 [PATCH 00/19] convert test -a/-o to && and || patch series Elia Pinto
2014-05-20 13:50 ` [PATCH 01/19] check_bindir: convert test -a/-o to && and || Elia Pinto
2014-05-20 18:12 ` Junio C Hamano
2014-05-20 18:54 ` Junio C Hamano
2014-05-20 13:50 ` [PATCH 02/19] contrib/examples/git-clone.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 03/19] contrib/examples/git-commit.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 04/19] contrib/examples/git-merge.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 05/19] contrib/examples/git-repack.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 06/19] contrib/examples/git-resolve.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 07/19] git-bisect.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 08/19] git-mergetool.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 09/19] git-rebase--interactive.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 10/19] git-submodule.sh: " Elia Pinto
2014-05-20 14:07 ` Matthieu Moy [this message]
2014-05-20 14:39 ` Johannes Sixt
2014-05-20 13:50 ` [PATCH 11/19] t/t0025-crlf-auto.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 12/19] t/t0026-eol-config.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 13/19] t/t4102-apply-rename.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 14/19] t/t5000-tar-tree.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 15/19] t/t5403-post-checkout-hook.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 16/19] t/t5537-fetch-shallow.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 17/19] t/t5538-push-shallow.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 18/19] t/t9814-git-p4-rename.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 19/19] t/test-lib-functions.sh: " Elia Pinto
2014-05-20 14:09 ` [PATCH 00/19] convert test -a/-o to && and || patch series Matthieu Moy
2014-05-20 17:57 ` Junio C Hamano
2014-05-20 18:22 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqegzo4k7g.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.