From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5 0/8] port the filtering part of branch.c to use ref-filter APIs
Date: Mon, 21 Sep 2015 08:23:18 +0200 [thread overview]
Message-ID: <vpqfv28e1ex.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAOLa=ZSyMV04wjhdM11RK9z8fz5tHM4PzPBxrN8_VA_Cacw82g@mail.gmail.com> (Karthik Nayak's message of "Mon, 21 Sep 2015 11:41:19 +0530")
Karthik Nayak <karthik.188@gmail.com> writes:
> On Mon, Sep 21, 2015 at 12:30 AM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> --- a/t/t3203-branch-output.sh
>>> +++ b/t/t3203-branch-output.sh
>>> @@ -145,8 +145,8 @@ EOF
>>>
>>> test_expect_success 'git branch `--sort` option' '
>>> cat >expect <<-\EOF &&
>>> - * (HEAD detached from fromtag)
>>> branch-two
>>> + * (HEAD detached from fromtag)
>>> branch-one
>>> master
>>> EOF
>>
>> I thought this was obviously wrong, but this tests uses
>> --sort=objectsize, so it's OK. Indeed, HEAD and branch-one have
>> objectsize=215, and branch-two has objectsize=167.
>>
>> So, the previous code was hardcoding "detached HEAD always comes first",
>> but we now sort the whole list, including detached HEAD, so branch-two
>> comes first.
>>
>
> Yeah! Even Junio said this was better, and even I think this is what
> the user would expect.
Yes, that was not an objection, just me thinking aloud during my review.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-09-21 6:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 18:10 [PATCH v5 0/8] port the filtering part of branch.c to use ref-filter APIs Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 1/8] branch: refactor width computation Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 2/8] branch: bump get_head_description() to the top Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 3/8] branch: roll show_detached HEAD into regular ref_list Karthik Nayak
2015-09-20 19:11 ` Matthieu Moy
2015-09-20 18:10 ` [PATCH v5 4/8] branch: move 'current' check down to the presentation layer Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 5/8] branch: drop non-commit error reporting Karthik Nayak
2015-09-20 19:16 ` Matthieu Moy
2015-09-21 10:20 ` Karthik Nayak
2015-09-21 11:35 ` Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 6/8] branch.c: use 'ref-filter' data structures Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 7/8] branch.c: use 'ref-filter' APIs Karthik Nayak
2015-09-20 19:24 ` Matthieu Moy
2015-09-21 10:21 ` Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 8/8] branch: add '--points-at' option Karthik Nayak
2015-09-20 19:00 ` [PATCH v5 0/8] port the filtering part of branch.c to use ref-filter APIs Matthieu Moy
2015-09-21 6:11 ` Karthik Nayak
2015-09-21 6:23 ` Matthieu Moy [this message]
2015-09-21 10:15 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqfv28e1ex.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.