From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Andrei Dinu <mandrei.dinu@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] diff-no-index.c read_directory() use is_dot_or_dotdot().
Date: Wed, 19 Mar 2014 16:21:18 +0100 [thread overview]
Message-ID: <vpqfvmefc41.fsf@anie.imag.fr> (raw)
In-Reply-To: <1395242180-4559-1-git-send-email-mandrei.dinu@gmail.com> (Andrei Dinu's message of "Wed, 19 Mar 2014 17:16:20 +0200")
> Subject: Re: [PATCH 1/3]
^^^
I guess you meant PATCH v3. 1/3 means that this is the first patch out
of 3.
Andrei Dinu <mandrei.dinu@gmail.com> writes:
> Implement read_directory() to use is_dot_or_dotdot() function from dir.h
> instead of strcmp().
>
> Rename read_directory() in read_directory_path() to avoid conflicting with
> read_directory() from dir.h.
Ideally, these should be two distinct patches. One to rename
read_directory (no real change), and the next one to use
is_dot_or_dotdot.
You may want to take this as an exercice to learn how to split a patch,
but I won't insist on that.
Other than that, the patch looks good.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2014-03-19 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 15:16 [PATCH 1/3] diff-no-index.c read_directory() use is_dot_or_dotdot() Andrei Dinu
2014-03-19 15:21 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqfvmefc41.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=mandrei.dinu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.