From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Karthik Nayak <karthik.188@gmail.com>,
git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH v17 05/14] ref-filter: introduce match_atom_name()
Date: Thu, 10 Sep 2015 18:59:06 +0200 [thread overview]
Message-ID: <vpqio7inrc5.fsf@scolette.imag.fr> (raw)
In-Reply-To: <xmqq37ym5i2u.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 10 Sep 2015 09:56:25 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> - } else if (starts_with(name, "color:")) {
>> + } else if (match_atom_name(name, "color", &valp)) {
>
> Why use the helper only for this one? Aren't existing calls to
> starts_with() in the same if/else if/... cascade all potential bugs
> that the new helper function is meant to help fixing? For example,
> the very fist one in the cascade:
>
> if (starts_with(name, "refname"))
> refname = ref->refname;
>
> is correct *ONLY* when name is "refname" or "refname:" followed by
> something, and it should skip "refnamex" when such a new atom is
> added to valid_atom[] list, i.e. a bug waiting to happen. I think
> the new helper is designed to prevent such a bug from happening.
I fully agree, but I also think that this should be a separate topic.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-09-10 16:59 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 15:48 [PATCH v17 00/14] port tag.c to use ref-filter APIs Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 01/14] ref-filter: move `struct atom_value` to ref-filter.c Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 02/14] ref-filter: introduce ref_formatting_state and ref_formatting_stack Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 03/14] utf8: add function to align a string into given strbuf Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 04/14] ref-filter: introduce handler function for each atom Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 05/14] ref-filter: introduce match_atom_name() Karthik Nayak
2015-09-10 16:49 ` Matthieu Moy
2015-09-10 17:23 ` Junio C Hamano
2015-09-10 18:58 ` Matthieu Moy
2015-09-10 16:56 ` Junio C Hamano
2015-09-10 16:59 ` Matthieu Moy [this message]
2015-09-10 18:25 ` Junio C Hamano
2015-09-10 17:00 ` Karthik Nayak
2015-09-10 17:28 ` Junio C Hamano
2015-09-10 17:35 ` Karthik Nayak
2015-09-10 17:45 ` Junio C Hamano
2015-09-10 17:49 ` Karthik Nayak
2015-09-11 14:59 ` Karthik Nayak
2015-09-11 15:01 ` [PATCH v17 06/14] ref-filter: implement an `align` atom Karthik Nayak
2015-09-10 15:48 ` Karthik Nayak
2015-09-10 16:53 ` Matthieu Moy
2015-09-10 16:59 ` Junio C Hamano
2015-09-11 15:03 ` Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 07/14] ref-filter: add option to filter out tags, branches and remotes Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 08/14] ref-filter: add support for %(contents:lines=X) Karthik Nayak
2015-09-10 17:14 ` Junio C Hamano
2015-09-10 17:37 ` Karthik Nayak
2015-09-11 15:04 ` Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 09/14] ref-filter: add support to sort by version Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 10/14] ref-filter: add option to match literal pattern Karthik Nayak
2015-09-10 15:48 ` [PATCH v17 11/14] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-09-10 16:22 ` [PATCH v17 12/14] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-09-11 15:06 ` Karthik Nayak
2015-09-10 16:22 ` [PATCH v17 13/14] tag.c: implement '--format' option Karthik Nayak
2015-09-10 17:59 ` Junio C Hamano
2015-09-10 18:04 ` Karthik Nayak
2015-09-11 15:06 ` Karthik Nayak
2015-09-10 16:22 ` [PATCH v17 14/14] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-09-17 21:36 ` John Keeping
2015-09-17 22:09 ` Junio C Hamano
2015-09-18 7:10 ` Matthieu Moy
2015-09-18 8:42 ` John Keeping
2015-09-18 9:13 ` Matthieu Moy
2015-09-18 15:10 ` Karthik Nayak
2015-09-18 15:19 ` Matthieu Moy
2015-09-18 15:22 ` Karthik Nayak
2015-09-18 15:30 ` Matthieu Moy
2015-09-18 15:38 ` Karthik Nayak
2015-09-18 15:44 ` Matthieu Moy
2015-09-10 16:57 ` [PATCH v17 00/14] port tag.c to use ref-filter APIs Matthieu Moy
2015-09-11 15:08 ` Karthik Nayak
2015-09-11 17:30 ` Eric Sunshine
2015-09-11 18:05 ` Junio C Hamano
2015-09-11 18:12 ` Karthik Nayak
2015-09-12 9:14 ` Matthieu Moy
2015-09-13 4:54 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqio7inrc5.fsf@scolette.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.