From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Sudhanshu Shekhar <sudshekhar02@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] reset: allow "-" short hand for previous commit
Date: Sun, 08 Mar 2015 11:33:51 +0100 [thread overview]
Message-ID: <vpqioeb22y8.fsf@anie.imag.fr> (raw)
In-Reply-To: <1425762244-8629-1-git-send-email-sudshekhar02@gmail.com> (Sudhanshu Shekhar's message of "Sun, 8 Mar 2015 02:34:04 +0530")
Sudhanshu Shekhar <sudshekhar02@gmail.com> writes:
> + if(!strcmp(argv[0], "-")) {
[...]
> diff --git a/builtin/reset.c b/builtin/reset.c
> index 9f8967d..02f33ef 100644
> --- a/builtin/reset.c
> +++ b/builtin/reset.c
> @@ -206,7 +206,7 @@ static void parse_args(struct pathspec *pathspec,
> */
>
> if (argv[0]) {
> - if(!strcmp(argv[0], "-")) {
> + if (!strcmp(argv[0], "-")) {
Please, squash this hunk into the previous patch, so that reviewers get
the right version right away.
Also, send each patch as a separate email (git send-email can do that
for you).
> + test_must_fail git reset - 2> output &&
Here and elsewhere: no space after >.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-03-08 10:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 20:51 [PATCH] reset: allow "-" short hand for previous commit Sudhanshu Shekhar
2015-03-03 22:10 ` Matthieu Moy
2015-03-03 23:17 ` Junio C Hamano
2015-03-04 7:07 ` Sudhanshu Shekhar
2015-03-04 7:09 ` Sudhanshu Shekhar
2015-03-04 7:10 ` Eric Sunshine
2015-03-05 0:34 ` Junio C Hamano
2015-03-07 21:04 ` [PATCH 1/2] " Sudhanshu Shekhar
2015-03-08 10:33 ` Matthieu Moy [this message]
2015-03-08 14:58 ` [PATCH 1/2] Teach reset the same short-hand as checkout Sudhanshu Shekhar
2015-03-08 14:58 ` [PATCH 2/2] Added test cases for git reset - Sudhanshu Shekhar
2015-03-08 18:09 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqioeb22y8.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sudshekhar02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.