From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Fairuzan Roslan <fairuzan.roslan@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: odb_mkstemp's 0444 permission broke write/delete access on AFP
Date: Mon, 16 Feb 2015 20:08:15 +0100 [thread overview]
Message-ID: <vpqiof14qu8.fsf@anie.imag.fr> (raw)
In-Reply-To: <340435D1-2FEB-4A4A-BBD2-E301096C72D8@gmail.com> (Fairuzan Roslan's message of "Tue, 17 Feb 2015 02:41:24 +0800")
[ Please, don't top post on this list ]
Fairuzan Roslan <fairuzan.roslan@gmail.com> writes:
> I don’t see the issue for the owner of his/her own file to have write
> access.
Object and pack files are not meant to be modified. Hence, they are
read-only so that an (accidental) attempt to modify them fails.
> Setting tmp idx & pack files to read-only even for the file owner is
> not a safety feature.
Yes it is. If you do not think so, then please give some arguments.
> You should at least give the user the option to set the permission in
> the config file and not hardcoded the permission in the binary.
This is the kind of thing I meant by "investigate alternate solutions".
I have no AFP share to test, so it would help if you answered the
question I asked in my previous message:
>> On Feb 17, 2015, at 2:23 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
>>
>> Fairuzan Roslan <fairuzan.roslan@gmail.com> writes:
>>
>>> Hi,
>>>
>>> Somehow the “int mode = 0444;” in odb_mkstemp (environment.c) are
>>> causing a lot of issues (unable to unlink/write/rename) to those
>>> people who use AFP shares.
>>
>> Is it a problem when using Git (like "git gc" failing to remove old
>> packs), or when trying to remove files outside Git?
(BTW, why did you try to write/rename pack files?)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-02-16 19:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 17:54 odb_mkstemp's 0444 permission broke write/delete access on AFP Fairuzan Roslan
2015-02-16 18:23 ` Matthieu Moy
2015-02-16 18:41 ` Fairuzan Roslan
2015-02-16 19:08 ` Matthieu Moy [this message]
2015-02-17 3:22 ` Fairuzan Roslan
2015-02-17 5:34 ` Torsten Bögershausen
2015-02-17 5:54 ` Fairuzan Roslan
2015-02-17 8:51 ` Matthieu Moy
2015-02-17 16:58 ` Fairuzan Roslan
2015-02-17 17:54 ` Torsten Bögershausen
2015-02-18 8:15 ` Matthieu Moy
2015-02-18 13:47 ` Fairuzan Roslan
2015-02-18 14:05 ` Matthieu Moy
2015-02-18 14:23 ` Fairuzan Roslan
2015-02-17 17:13 ` Junio C Hamano
2015-02-18 17:04 ` Matthieu Moy
2015-02-18 17:13 ` Junio C Hamano
2015-02-18 17:31 ` Junio C Hamano
2015-02-19 20:08 ` brian m. carlson
2015-02-20 10:40 ` Matthieu Moy
2015-02-16 19:06 ` Junio C Hamano
2015-02-16 19:50 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqiof14qu8.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=fairuzan.roslan@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.