From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: benoit.person@ensimag.fr
Cc: git@vger.kernel.org, Celestin Matte <celestin.matte@ensimag.fr>
Subject: Re: [PATCH v4 5/5] git-remote-mediawiki: Add preview subcommand into git mw.
Date: Thu, 20 Jun 2013 10:53:56 +0200 [thread overview]
Message-ID: <vpqip19duxn.fsf@anie.imag.fr> (raw)
In-Reply-To: <1371712593-6210-6-git-send-email-benoit.person@ensimag.fr> (benoit person's message of "Thu, 20 Jun 2013 09:16:33 +0200")
benoit.person@ensimag.fr writes:
> +# @TODO : add documentation for verbose option
I guess that's not applicable anymore.
> +distant mediawiki and combined with a template retrieved from the mediawiki.
s/distant/remote/
> +sub preview {
> + my $wiki;
> + my ($remote_url, $wiki_page_name);
> + my ($new_content, $template);
> + my $file_content;
> +
> + if ($file_name eq EMPTY) {
> + die "Missing file argument, see `git mw help` \n";
Unneeded space before \n.
> + for (@{ $html_tree->extract_links() }) {
> + my ($link, $element, $attr) = @{ $_ };
> + my $url = url($link)->canonical;
> + $element->attr($attr, URI->new_abs($url, $remote_url));
> + }
Extracting this into a function like "make_links_absolute" would have
made it clearer.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-06-20 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 7:16 [PATCH v4 0/5] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-06-20 7:16 ` [PATCH v4 1/5] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person
2013-06-20 8:30 ` Matthieu Moy
2013-06-20 7:16 ` [PATCH v4 2/5] git-remote-mediawiki: new git bin-wrapper for developement benoit.person
2013-06-20 8:40 ` Matthieu Moy
2013-06-20 7:16 ` [PATCH v4 3/5] git-remote-mediawiki: factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person
2013-06-20 7:16 ` [PATCH v4 4/5] git-remote-mediawiki: Adding git-mw command benoit.person
2013-06-20 7:16 ` [PATCH v4 5/5] git-remote-mediawiki: Add preview subcommand into git mw benoit.person
2013-06-20 8:53 ` Matthieu Moy [this message]
2013-06-20 9:45 ` Matthieu Moy
2013-06-20 8:55 ` [PATCH v4 0/5] git-remote-mediawiki: new tool to preview local changes without pushing Matthieu Moy
2013-06-20 11:21 ` Benoît Person
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqip19duxn.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.