From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Armin Kunaschik <megabreit@googlemail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: t7800 test failure
Date: Tue, 24 May 2016 18:48:57 +0200 [thread overview]
Message-ID: <vpqk2ijs8p2.fsf@anie.imag.fr> (raw)
In-Reply-To: <CALR6jEiJwx14zAyond9ggz29Q64Fz84URtjr8zaddjnrdY7TjA@mail.gmail.com> (Armin Kunaschik's message of "Tue, 24 May 2016 17:53:25 +0200")
Armin Kunaschik <megabreit@googlemail.com> writes:
> t7800 fails on systems where readlink (GNUism?) is not available.
I don't think it's POSIX, but it is present on all POSIX-like systems I
know. On which system did you get the issue?
> +readlink() { ls -ld "$1" | sed 's/.* -> //'; }
This is much less robust than the actual readlink. For example, if ->
appears in the link name, it breaks.
It would be acceptable as a fall-back if readlink is not present, but
shouldn't activate the "ls" hack by default.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-05-24 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 15:53 t7800 test failure Armin Kunaschik
2016-05-24 16:48 ` Matthieu Moy [this message]
2016-05-24 16:57 ` Junio C Hamano
2016-05-24 17:20 ` Armin Kunaschik
2016-05-24 17:36 ` Junio C Hamano
2016-05-25 9:33 ` Armin Kunaschik
2016-05-27 4:19 ` David Aguilar
2016-05-27 7:48 ` Matthieu Moy
2016-05-31 0:26 ` [PATCH] t7800 readlink not found Armin Kunaschik
2016-05-31 5:06 ` Torsten Bögershausen
2016-05-31 5:51 ` Junio C Hamano
2016-06-21 14:44 ` Armin Kunaschik
2016-06-21 18:39 ` Junio C Hamano
2016-06-21 20:30 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqk2ijs8p2.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=megabreit@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.