From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Tanay Abhra <tanayabh@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v6 0/3] git config cache & special querying api utilizing the cache
Date: Mon, 07 Jul 2014 19:10:38 +0200 [thread overview]
Message-ID: <vpqlhs5w0vl.fsf@anie.imag.fr> (raw)
In-Reply-To: <1404719566-3368-1-git-send-email-tanayabh@gmail.com> (Tanay Abhra's message of "Mon, 7 Jul 2014 00:52:44 -0700")
Tanay Abhra <tanayabh@gmail.com> writes:
> test_expect_success 'find value with misspelled key' '
> - echo "Value not found for \"my.fOo Bar.hi\"" >expect &&
> - test_must_fail test-config get_value "my.fOo Bar.hi" >actual &&
> - test_cmp expect actual
> + check "my.fOo Bar.hi" "Value not found for \"my.fOo Bar.hi\""
> '
This one is wrong: you did need the test_must_fail here.
(That's related to my other message about &&-chaining in check)
Other than my minor remarks, the patches now sounds good. Tanay: you
should be able to send a v7 very soon, and it should hopefully be ready
for pu.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-07 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 7:52 [PATCH v6 0/3] git config cache & special querying api utilizing the cache Tanay Abhra
2014-07-07 7:52 ` [PATCH v6 1/2] add `config_set` API for caching config-like files Tanay Abhra
2014-07-07 7:52 ` [PATCH v6 2/2] test-config: Add tests for the config_set API Tanay Abhra
2014-07-07 17:04 ` Matthieu Moy
2014-07-09 11:15 ` Tanay Abhra
2014-07-09 12:10 ` Matthieu Moy
2014-07-07 17:10 ` Matthieu Moy [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-09 10:57 [PATCH v6 0/3] git config cache & special querying api utilizing the cache Tanay Abhra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqlhs5w0vl.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.