From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: "Célestin Matte" <celestin.matte@ensimag.fr>
Cc: git@vger.kernel.org, benoit.person@ensimag.fr
Subject: Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp
Date: Sat, 08 Jun 2013 20:38:56 +0200 [thread overview]
Message-ID: <vpqmwr0v45b.fsf@anie.imag.fr> (raw)
In-Reply-To: <1370698510-11649-1-git-send-email-celestin.matte@ensimag.fr> ("Célestin Matte"'s message of "Sat, 8 Jun 2013 15:35:10 +0200")
Célestin Matte <celestin.matte@ensimag.fr> writes:
> In Perl, '\n' is not a newline, but instead a literal backslash followed by an
> "n". As the output of "rev-list --first-parent" is line-oriented, what we want
> here is a newline.
This is right, but the code actually worked the way it was. I'm not
sure, but my understanding is that '\n' is the string "backslash
followed by n", but interpreted as a regexp, it is a newline.
The new code looks better than the old one, but the log message may be
improved.
In any case, Acked-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-06-08 18:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 13:35 [PATCH] git-remote-mediawiki: Fix a bug in a regexp Célestin Matte
2013-06-08 18:38 ` Matthieu Moy [this message]
2013-06-08 20:08 ` Célestin Matte
2013-06-09 2:57 ` Jeff King
2013-06-09 5:21 ` Eric Sunshine
2013-06-09 5:11 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqmwr0v45b.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.