From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: git@vger.kernel.org, Nanako Shiraishi <nanako3@lavabit.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] rebase -i: remove undocumented '--verify' flag
Date: Mon, 22 Nov 2010 13:53:57 +0100 [thread overview]
Message-ID: <vpqoc9hsemy.fsf@bauges.imag.fr> (raw)
In-Reply-To: <1290408504-14639-1-git-send-email-martin.von.zweigbergk@gmail.com> (Martin von Zweigbergk's message of "Mon\, 22 Nov 2010 07\:48\:24 +0100")
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:
> Remove the undocumented and unused '--verify' flag from interactive
> rebase.
I don't think this change is good. If a command has a --no-whatever
flag, one expects the --whatever flag to exist too, even if it's a
no-op.
> --no-verify)
> OK_TO_SKIP_PRE_REBASE=yes
> ;;
--no-verify exists, so
> - --verify)
> - ;;
--verify exists too.
I think a better change would be to add a comment like
--verify)
# no-op, exists because --no-verify exists too.
;;
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-11-22 12:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 6:48 [PATCH] rebase -i: remove undocumented '--verify' flag Martin von Zweigbergk
2010-11-22 12:53 ` Matthieu Moy [this message]
2010-11-22 13:14 ` Thomas Rast
2010-11-22 13:29 ` Matthieu Moy
2010-11-22 20:21 ` Martin von Zweigbergk
2010-11-23 2:24 ` Kevin Ballard
2010-11-23 14:41 ` Jeff King
2010-11-23 20:08 ` Junio C Hamano
2010-11-23 20:14 ` Junio C Hamano
2010-11-24 1:09 ` Martin von Zweigbergk
2010-11-22 13:49 ` Martin von Zweigbergk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqoc9hsemy.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.