From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Thomas Rast <trast@inf.ethz.ch>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] Show items of interactive git-clean in columns
Date: Thu, 02 May 2013 17:03:25 +0200 [thread overview]
Message-ID: <vpqppx9fmpu.fsf@grenoble-inp.fr> (raw)
In-Reply-To: <3b80db3d2e8f31b1d9373406cce3cbdee2094a29.1367500374.git.worldhello.net@gmail.com> (Jiang Xin's message of "Thu, 2 May 2013 21:15:03 +0800")
Jiang Xin <worldhello.net@gmail.com> writes:
> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
This lacks a proper commit message (why is this a good thing?), and
documentation (you introduce column.clean) but the code sounds good
(that's a very quick look from me, not a "review" sorry).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-05-02 15:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 8:07 [PATCH] clean: confirm before cleaning files and directories Jiang Xin
2013-04-26 8:21 ` Matthieu Moy
2013-04-26 8:41 ` Jiang Xin
2013-04-26 8:51 ` Matthieu Moy
2013-04-26 10:00 ` Jiang Xin
2013-04-26 8:53 ` Thomas Rast
2013-04-26 16:10 ` Junio C Hamano
2013-04-26 16:19 ` Matthieu Moy
2013-04-26 17:07 ` Junio C Hamano
2013-04-26 19:06 ` Junio C Hamano
2013-04-27 2:09 ` Jiang Xin
2013-04-27 16:13 ` [PATCH v2] Add support for -i/--interactive to git-clean Jiang Xin
2013-04-27 21:41 ` Matthieu Moy
2013-04-27 23:11 ` Junio C Hamano
2013-04-28 2:03 ` Eric Sunshine
2013-04-29 8:03 ` Matthieu Moy
2013-04-29 14:30 ` [PATCH] clean: Introduce -z for machine readable output Michael J Gruber
2013-04-29 14:45 ` Matthieu Moy
2013-04-29 16:15 ` [PATCH v2] Add support for -i/--interactive to git-clean Jiang Xin
2013-04-30 19:25 ` [PATCH v3] " Jiang Xin
2013-05-01 15:12 ` Matthieu Moy
2013-05-02 13:15 ` [PATCH v4 1/3] " Jiang Xin
2013-05-02 13:15 ` [PATCH v4 2/3] Show items of interactive git-clean in columns Jiang Xin
2013-05-02 15:03 ` Matthieu Moy [this message]
2013-05-03 1:26 ` Jiang Xin
2013-05-03 12:54 ` Matthieu Moy
2013-05-02 13:15 ` [PATCH v4 3/3] Add colors to interactive git-clean Jiang Xin
2013-05-02 15:07 ` Matthieu Moy
2013-05-03 2:53 ` Jiang Xin
2013-05-02 13:43 ` [PATCH v3] Add support for -i/--interactive to git-clean Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqppx9fmpu.fsf@grenoble-inp.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=trast@inf.ethz.ch \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.