From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Tanay Abhra <tanayabh@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH v3 4/6] add a test for semantic errors in config files
Date: Mon, 28 Jul 2014 13:38:41 +0200 [thread overview]
Message-ID: <vpqr415r9vi.fsf@anie.imag.fr> (raw)
In-Reply-To: <53D63389.5090205@gmail.com> (Tanay Abhra's message of "Mon, 28 Jul 2014 16:57:05 +0530")
Tanay Abhra <tanayabh@gmail.com> writes:
> On 7/28/2014 4:52 PM, Matthieu Moy wrote:
>> Tanay Abhra <tanayabh@gmail.com> writes:
>>
>>> +test_expect_success 'check line errors for malformed values' '
>>> + mv .git/config .git/config.old &&
>>> + test_when_finished "mv .git/config.old .git/config" &&
>>> + cat >.git/config <<-\EOF &&
>>> + [alias]
>>> + br
>>> + EOF
>>> + test_expect_code 128 git br 2>result &&
>>> + grep "fatal: bad config file line 2 in .git/config" result
>>> +'
>>
>> This is PATCH 4, and it tests a bug fixed in PATCH 1. It would have
>> eased review to group both patches, either
>>
>> PATCH 1: introduce test_expect_failure test to demonstrate the failure
>
> Didn't Junio comment that he wouldn't recommend inserting a test_expect_failure
> for new tests and then flipping them after in the series.
No, he even said it was good practice:
http://thread.gmane.org/gmane.comp.version-control.git/254101/focus=254104
his point was to avoid breaking something and repairing in another patch
(which your initial series was doing because the test patch was coming
between "rewrite git_config() to use the config-set API" and "add line
number and file name info to `config_set`").
The situation is different when you have a pre-existing bug.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-28 11:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 10:33 [PATCH v3 0/6] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-28 10:33 ` [PATCH v3 1/6] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-28 10:33 ` [PATCH v3 2/6] add line number and file name info to `config_set` Tanay Abhra
2014-07-28 10:33 ` [PATCH v3 3/6] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-28 10:33 ` [PATCH v3 4/6] add a test for semantic errors in config files Tanay Abhra
2014-07-28 11:22 ` Matthieu Moy
2014-07-28 11:27 ` Tanay Abhra
2014-07-28 11:38 ` Matthieu Moy [this message]
2014-07-28 10:33 ` [PATCH v3 5/6] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-28 10:55 ` Ramsay Jones
2014-07-28 11:02 ` Tanay Abhra
2014-07-28 11:16 ` Matthieu Moy
2014-07-28 11:14 ` Matthieu Moy
2014-07-28 10:33 ` [PATCH v3 6/6] add tests for `git_config_get_string_const()` Tanay Abhra
2014-07-28 11:24 ` [PATCH v3 0/6] Rewrite `git_config()` using config-set API Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqr415r9vi.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.