All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
	Andrew Ardill <andrew.ardill@gmail.com>,
	Michael Haggerty <mhagger@alum.mit.edu>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Thorsten Glaser <tg@mirbsd.de>,
	"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git should not use a default user.email config value
Date: Wed, 14 Aug 2013 16:07:44 +0200	[thread overview]
Message-ID: <vpqr4dwl61b.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAPc5daWqzTkMFkecrAjMCmxwZZrgUtB-FVKrjsmfvpgwPgF8AA@mail.gmail.com> (Junio C. Hamano's message of "Wed, 14 Aug 2013 07:00:58 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> On Wed, Aug 14, 2013 at 1:37 AM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>>
>> Jeff King <peff@peff.net> writes:
>>
>> > This whole discussion is basically implementing conditional config.
>> > [...] The problem is that it would be tricky to do in a
>> > backwards-compatible way.
>>
>> That could be done with "conditional comments" like
>>
>> # if <some-condition> then
>> [core]
>>         pager = less
>> # endif
>>
>> That's rather ugly, and the implementation would be even more ugly, but
>> backward-compatible.
>
>
> I highly doubt that you would want to be "backward compatible" in this
> case, though.
> The section of the configuration you are enclosing the new if/endif
> syntax may be
> understood only by newer Git (e.g. imagine core.pager is still
> bool-only today), and
> older Git that do not understand if/endif syntax will happily read
> that section and
> choke on it, no?

Indeed. That would be more

# if <some-condition> then
# [core]
#       pager = less
# endif

which is even more ugly ;-).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2013-08-14 14:09 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130809134236.28143.75775.reportbug@tglase.lan.tarent.de>
2013-08-09 19:42 ` git should not use a default user.email config value Jonathan Nieder
2013-08-09 20:00   ` Thorsten Glaser
2013-08-09 20:30     ` Felipe Contreras
2013-08-13  8:29       ` Matthieu Moy
2013-08-09 22:37   ` Jeff King
2013-08-09 23:06     ` Junio C Hamano
2013-08-10  6:17       ` Jeff King
2013-08-10  6:40         ` Jonathan Nieder
2013-08-10  6:52           ` Jeff King
2013-08-10  7:03             ` Jonathan Nieder
2013-08-10  7:14               ` Jeff King
2013-08-09 23:19     ` Jonathan Nieder
2013-08-10  6:47       ` Jeff King
2013-08-10  9:59         ` Michael Haggerty
2013-08-10 10:28           ` Jeff King
2013-08-10 11:42             ` Michael Haggerty
2013-08-10 12:06             ` Thorsten Glaser
2013-08-10 12:34             ` Andreas Schwab
2013-08-12 12:51             ` Greg Troxel
2013-08-10 16:58           ` Junio C Hamano
2013-08-12 11:52             ` Andrew Ardill
2013-08-12 12:39               ` Jeff King
2013-08-12 12:54                 ` Michael Haggerty
2013-08-12 15:49                   ` Jeff King
2013-08-12 13:01                 ` Andrew Ardill
2013-08-12 15:45                   ` Jeff King
2013-08-13 11:05                     ` Andrew Ardill
2013-08-13 11:46                       ` Jeff King
2013-08-13 12:05                         ` Jeff King
2013-08-13 12:52                         ` Andrew Ardill
2013-08-13 15:53                           ` Jeff King
2013-08-13 16:33                         ` Junio C Hamano
2013-08-14  7:28                           ` Matthieu Moy
2013-08-14  7:40                             ` Jeff King
2013-08-14  8:37                               ` Matthieu Moy
2013-08-14 14:00                                 ` Junio C Hamano
2013-08-14 14:07                                   ` Matthieu Moy [this message]
2013-08-14 14:08                                   ` conditional config syntax Jeff King
2013-08-14 15:41                                     ` Junio C Hamano
2013-08-14  7:09                         ` git should not use a default user.email config value Michael Haggerty
2013-08-14  7:31                           ` Jeff King
2013-08-13 16:31                 ` Junio C Hamano
2013-08-13  8:08             ` Matthieu Moy
2013-08-11  0:06           ` Aaron Schrab
2013-08-13  8:24   ` Matthieu Moy
2013-08-13  8:39     ` Thorsten Glaser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqr4dwl61b.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=andrew.ardill@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    --cc=tg@mirbsd.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.